[webkit-changes] [WebKit/WebKit] 881ba2: [AutoInstall] Remove any manifest item on failure

Sam Sneddon noreply at github.com
Thu Dec 5 18:54:48 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 881ba2ce3758ee4769818e3a7a9efb9417965c03
      https://github.com/WebKit/WebKit/commit/881ba2ce3758ee4769818e3a7a9efb9417965c03
  Author: Sam Sneddon <gsnedders at apple.com>
  Date:   2024-12-05 (Thu, 05 Dec 2024)

  Changed paths:
    M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py

  Log Message:
  -----------
  [AutoInstall] Remove any manifest item on failure
https://bugs.webkit.org/show_bug.cgi?id=284086

Reviewed by Jonathan Bedard.

We had an EWS bot in a state where the manifest said something was
installed but it was not, likely due to installation failing.

When we're changing what version of a package is installed,
installation failing can lead us to a state where we have neither the
new nor old version installed, but the manifest would claim that the
old version still was.

To fix this, we delete any relevant manifest item on failure, which
will force a reinstall (of either version) in the future.

Untested, because of https://bugs.webkit.org/show_bug.cgi?id=284070.

* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
(Package.install):

Canonical link: https://commits.webkit.org/287426@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list