[webkit-changes] [WebKit/WebKit] 6346e2: Disconnect RemoteFrameView when destroying a Page ...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6346e2e79c3e9ed48ae1d3f99ab38b104eca6dd2
      https://github.com/WebKit/WebKit/commit/6346e2e79c3e9ed48ae1d3f99ab38b104eca6dd2
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-12-04 (Wed, 04 Dec 2024)

  Changed paths:
    M Source/WebCore/page/Page.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm

  Log Message:
  -----------
  Disconnect RemoteFrameView when destroying a Page with a RemoteFrame as the main frame
https://bugs.webkit.org/show_bug.cgi?id=284084

Reviewed by Charlie Wolfe.

If a Page has a RemoteFrame as its main frame, we need to break the reference cycle
between the Frame and the FrameView or the Frame will never be deallocated.  This caused
issues when the WebProcessCache was enabled.

* Source/WebCore/page/Page.cpp:
(WebCore::Page::~Page):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST(SiteIsolation, ProcessReuse)):

Canonical link: https://commits.webkit.org/287380@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications