[webkit-changes] [WebKit/WebKit] ed142d: Stop taking unbounded network assertion in host ap...

bnham noreply at github.com
Wed Dec 4 16:09:33 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ed142da66dbff90e39c31856eabb53af5ff9318d
      https://github.com/WebKit/WebKit/commit/ed142da66dbff90e39c31856eabb53af5ff9318d
  Author: Ben Nham <nham at apple.com>
  Date:   2024-12-04 (Wed, 04 Dec 2024)

  Changed paths:
    M Source/WebKit/NetworkProcess/Downloads/cocoa/DownloadCocoa.mm
    M Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp
    M Source/WebKit/UIProcess/Downloads/DownloadProxy.h
    M Source/WebKit/UIProcess/Downloads/DownloadProxy.messages.in
    M Source/WebKit/UIProcess/Downloads/DownloadProxyCocoa.mm
    M Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp

  Log Message:
  -----------
  Stop taking unbounded network assertion in host app for downloads
https://bugs.webkit.org/show_bug.cgi?id=284052
rdar://140156066

Reviewed by Per Arne Vollan.

Now that we've moved assertion management for downloads to dasd (284764 at main), we should also remove
the unbounded networking assertion for the host app. Instead we should keep the host app running
only long enough until it starts receiving progress updates, at which point it should be safe to
suspend the host app.

* Source/WebKit/NetworkProcess/Downloads/cocoa/DownloadCocoa.mm:
(WebKit::Download::startUpdatingProgress):
* Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::m_assertion):
* Source/WebKit/UIProcess/Downloads/DownloadProxy.h:
* Source/WebKit/UIProcess/Downloads/DownloadProxy.messages.in:
* Source/WebKit/UIProcess/Downloads/DownloadProxyCocoa.mm:
(WebKit::DownloadProxy::startUpdatingProgress):
* Source/WebKit/UIProcess/Downloads/DownloadProxyMap.cpp:
(WebKit::DownloadProxyMap::DownloadProxyMap):

Canonical link: https://commits.webkit.org/287370@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list