[webkit-changes] [WebKit/WebKit] 1357bd: [WebGPUSwift] move internal headers to WebGPU_Inte...

nmahendru noreply at github.com
Wed Dec 4 15:42:30 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1357bd02984ffa9c99bdb69606af675ae3b7a8e9
      https://github.com/WebKit/WebKit/commit/1357bd02984ffa9c99bdb69606af675ae3b7a8e9
  Author: Nitin Mahendru <nitinmahendru at apple.com>
  Date:   2024-12-04 (Wed, 04 Dec 2024)

  Changed paths:
    M Source/WebGPU/WebGPU.xcodeproj/project.pbxproj
    M Source/WebGPU/WebGPU/Adapter.h
    M Source/WebGPU/WebGPU/Buffer.h
    M Source/WebGPU/WebGPU/CommandEncoder.h
    M Source/WebGPU/WebGPU/Device.h
    M Source/WebGPU/WebGPU/HardwareCapabilities.h
    M Source/WebGPU/WebGPU/Internal/WebGPUSwiftInternal.h
    M Source/WebGPU/WebGPU/QuerySet.h
    M Source/WebGPU/WebGPU/Texture.h
    M Source/WebGPU/WebGPU/WebGPUExt.h

  Log Message:
  -----------
  [WebGPUSwift] move internal headers to WebGPU_Internal module
https://bugs.webkit.org/show_bug.cgi?id=283544
rdar://140394391

Reviewed by Mike Wyrzykowski and Elliott Williams.

Currently there is a long list of headers at the bottom of WebGPUExt.h that
were added to let them be imported into Swift via WebGPU.modulemap.
Although they are hidden behing the flag __WEBGPU__, the headers still live in
WebGPU.modulemap which is wrong philosophically as these headers are only to be
consumed by Swift in WebGPU.
Now, since we have another internal module i.e. WebGPU_Internal, it's cleaner
to move them there.
This should not cause any change in functionality.

* Source/WebGPU/WebGPU.xcodeproj/project.pbxproj:
* Source/WebGPU/WebGPU/Adapter.h:
* Source/WebGPU/WebGPU/Buffer.h:
* Source/WebGPU/WebGPU/CommandEncoder.h:
* Source/WebGPU/WebGPU/Device.h:
* Source/WebGPU/WebGPU/HardwareCapabilities.h:
* Source/WebGPU/WebGPU/Internal/WebGPUSwiftInternal.h:
* Source/WebGPU/WebGPU/QuerySet.h:
* Source/WebGPU/WebGPU/Texture.h:
* Source/WebGPU/WebGPU/WebGPUExt.h:

Canonical link: https://commits.webkit.org/287367@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list