[webkit-changes] [WebKit/WebKit] 490f61: Stop using WTF_ALLOW_UNSAFE_BUFFER_USAGE in WebCor...

Chris Dumez noreply at github.com
Wed Dec 4 15:07:00 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 490f610d13ba000918520c7bb501a7c458b93142
      https://github.com/WebKit/WebKit/commit/490f610d13ba000918520c7bb501a7c458b93142
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-12-04 (Wed, 04 Dec 2024)

  Changed paths:
    M Source/WTF/wtf/CryptographicUtilities.cpp
    M Source/WTF/wtf/CryptographicUtilities.h
    M Source/WebCore/crypto/algorithms/CryptoAlgorithmAESCTR.cpp
    M Source/WebCore/crypto/algorithms/CryptoAlgorithmAESGCM.cpp
    M Source/WebCore/crypto/algorithms/CryptoAlgorithmX25519.cpp
    M Source/WebCore/crypto/cocoa/CryptoAlgorithmAESCBCMac.cpp
    M Source/WebCore/crypto/cocoa/CryptoAlgorithmAESCFBMac.cpp
    M Source/WebCore/crypto/cocoa/CryptoAlgorithmAESGCMMac.cpp
    M Source/WebCore/crypto/cocoa/CryptoAlgorithmECDSAMac.cpp
    M Source/WebCore/crypto/cocoa/CryptoAlgorithmHMACMac.cpp
    M Source/WebCore/crypto/cocoa/CryptoKeyECMac.cpp
    M Source/WebCore/crypto/cocoa/CryptoKeyOKPCocoa.cpp
    M Source/WebCore/crypto/cocoa/CryptoKeyRSAMac.cpp
    M Source/WebCore/crypto/cocoa/CryptoUtilitiesCocoa.cpp
    M Source/WebCore/crypto/cocoa/SerializedCryptoKeyWrapMac.mm
    M Source/WebCore/crypto/gcrypt/CryptoAlgorithmAESGCMGCrypt.cpp
    M Source/WebCore/crypto/gcrypt/CryptoAlgorithmHMACGCrypt.cpp
    M Source/WebCore/crypto/openssl/CryptoAlgorithmHMACOpenSSL.cpp

  Log Message:
  -----------
  Stop using WTF_ALLOW_UNSAFE_BUFFER_USAGE in WebCore/crypto/
https://bugs.webkit.org/show_bug.cgi?id=284018

Reviewed by Darin Adler.

* Source/WTF/wtf/CryptographicUtilities.cpp:
(WTF::constantTimeMemcmp):
* Source/WTF/wtf/CryptographicUtilities.h:
(WTF::constantTimeMemcmp):
* Source/WebCore/crypto/algorithms/CryptoAlgorithmAESCTR.cpp:
(WebCore::parametersAreValid):
(WebCore::CryptoAlgorithmAESCTR::CounterBlockHelper::CounterBlockHelper):
(WebCore::CryptoAlgorithmAESCTR::CounterBlockHelper::counterVectorAfterOverflow const):
(WebCore::CryptoAlgorithmAESCTR::CounterBlockHelper::CounterBlockBits::set):
(WebCore::CryptoAlgorithmAESCTR::CounterBlockHelper::CounterBlockBits::all const):
* Source/WebCore/crypto/algorithms/CryptoAlgorithmAESGCM.cpp:
(WebCore::tagLengthIsValid):
* Source/WebCore/crypto/algorithms/CryptoAlgorithmX25519.cpp:
(WebCore::CryptoAlgorithmX25519::deriveBits):
* Source/WebCore/crypto/cocoa/CryptoAlgorithmAESCBCMac.cpp:
(WebCore::transformAESCBC):
* Source/WebCore/crypto/cocoa/CryptoAlgorithmAESCFBMac.cpp:
(WebCore::transformAESCFB):
* Source/WebCore/crypto/cocoa/CryptoAlgorithmAESGCMMac.cpp:
(WebCore::decyptAESGCM):
* Source/WebCore/crypto/cocoa/CryptoAlgorithmECDSAMac.cpp:
* Source/WebCore/crypto/cocoa/CryptoAlgorithmHMACMac.cpp:
(WebCore::platformVerifyCC):
* Source/WebCore/crypto/cocoa/CryptoKeyECMac.cpp:
* Source/WebCore/crypto/cocoa/CryptoKeyOKPCocoa.cpp:
* Source/WebCore/crypto/cocoa/CryptoKeyRSAMac.cpp:
(WebCore::CryptoKeyRSA::importSpki):
(WebCore::CryptoKeyRSA::importPkcs8):
* Source/WebCore/crypto/cocoa/CryptoUtilitiesCocoa.cpp:
(WebCore::transformAESCTR):
* Source/WebCore/crypto/cocoa/SerializedCryptoKeyWrapMac.mm:
(WebCore::unwrapCryptoKey):
* Source/WebCore/crypto/gcrypt/CryptoAlgorithmAESGCMGCrypt.cpp:
(WebCore::gcryptDecrypt):
* Source/WebCore/crypto/gcrypt/CryptoAlgorithmHMACGCrypt.cpp:
(WebCore::CryptoAlgorithmHMAC::platformVerify):
* Source/WebCore/crypto/openssl/CryptoAlgorithmHMACOpenSSL.cpp:
(WebCore::CryptoAlgorithmHMAC::platformVerify):

Canonical link: https://commits.webkit.org/287365@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list