[webkit-changes] [WebKit/WebKit] 94fb48: [Static Analyzer CI] Filter unexpected results usi...

[Brianna Fan]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 94fb4893473fce89ffca8bfc7a9dcab2842a14f6
      https://github.com/WebKit/WebKit/commit/94fb4893473fce89ffca8bfc7a9dcab2842a14f6
  Author: Brianna Fan <bfan2 at apple.com>
  Date:   2024-12-04 (Wed, 04 Dec 2024)

  Changed paths:
    M Tools/CISupport/ews-build/steps.py
    M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  -----------
  [Static Analyzer CI] Filter unexpected results using results.webkit.org to reduce build times on EWS
https://bugs.webkit.org/show_bug.cgi?id=282770
rdar://139393719

Reviewed by Jonathan Bedard.

Consult results.webkit.org on the first run of FindUnexpectedStaticAnalyzerResults to determine if
failures and successes on the PR are pre-existing. If so, we can filter those results out.

* Tools/CISupport/ews-build/steps.py:

(FindUnexpectedStaticAnalyzerResults):
    - If self.expectations = True (1st run on PR):
          - Check results database for each unexpected result
           1. If it fails, fall back to rebuilding on ToT.
           2. If it succeeds with no changes, run GenerateSaferCPPResultsIndex, Delete, Archive,
              Upload, Extract, & Display results.
           3. If it succeeds with changes, run DownloadUnexpectedResultsFromMaster, DeleteStaticAnalyzerResults,
              GenerateSaferCPPResultsIndex, then Archive, Upload, Extract, & Display results.
    - If self.expectations = False (2nd run on ToT):
          - These are not new changes and are already running.
          - Compare the PR and ToT results. Then run Archive, Upload, Extract, & Display results.
          - Upload ToT results to results.webkit.org.

(FindUnexpectedStaticAnalyzerResults.run): Add new logic for each case enumerated above.
(FindUnexpectedStaticAnalyzerResults.filter_results_using_results_db): Added.
(FindUnexpectedStaticAnalyzerResults.check_results_db): Added.
(FindUnexpectedStaticAnalyzerResults.find_unexpected_results): Added.
(FindUnexpectedStaticAnalyzerResults.createResultMessage): Added.

Canonical link: https://commits.webkit.org/287360@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications