[webkit-changes] [WebKit/WebKit] e68981: AVVideoCaptureSource should set its videoRotationA...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e68981fdfb44b0609b09a05183184de21687dc44
      https://github.com/WebKit/WebKit/commit/e68981fdfb44b0609b09a05183184de21687dc44
  Author: Youenn Fablet <youenn at apple.com>
  Date:   2024-12-04 (Wed, 04 Dec 2024)

  Changed paths:
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h
    M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm
    M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp

  Log Message:
  -----------
  AVVideoCaptureSource should set its videoRotationAngle to zero
rdar://140401914
https://bugs.webkit.org/show_bug.cgi?id=283962

Reviewed by Eric Carlson.

Landscape left camera devices will set videoRotationAngle to 180 to support applications that are not using the device rotation coordinator API.
Given WebKit is now using this API, we have to set it back to 0, which will remove an unneeded rotation done at AV level.
We only do this rotation if the preference flag to use the coordinator API is enabled.

Manually tested.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h:
* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::setUseAVCaptureDeviceRotationCoordinatorAPI):
(WebCore::AVVideoCaptureSource::setupCaptureSession):
* Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:

Canonical link: https://commits.webkit.org/287348@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications