[webkit-changes] [WebKit/WebKit] 74d540: [GStreamer][WebRTC] rvfc metadata fixes

Philippe Normand noreply at github.com
Wed Dec 4 00:58:31 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 74d540d7d086755cda1c1bb0af4eb276ec163f8f
      https://github.com/WebKit/WebKit/commit/74d540d7d086755cda1c1bb0af4eb276ec163f8f
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-12-04 (Wed, 04 Dec 2024)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
    M Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.cpp
    M Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.h
    M Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp

  Log Message:
  -----------
  [GStreamer][WebRTC] rvfc metadata fixes
https://bugs.webkit.org/show_bug.cgi?id=283961

Reviewed by Xabier Rodriguez-Calvar.

The video capturer pipeline wasn't attaching capture time metadata to the buffers and on the
receiving side the NTP timestamp was interpreted without taking into account the right time offset
between 1900/01/01 and 1970/01/01 which is the UNIX epoch. Also on the receiving side there's no
need to attach the metadata to every RTP packet, but only to the last one corresponding to the frame
boundary.

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::videoFrameMetadata):
* Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.cpp:
(WebCore::GStreamerIncomingTrackProcessor::incomingTrackProcessor):
(WebCore::GStreamerIncomingTrackProcessor::createParser):
(WebCore::GStreamerIncomingTrackProcessor::installRtpBufferPadProbe):
* Source/WebCore/platform/mediastream/gstreamer/GStreamerIncomingTrackProcessor.h:
* Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCapturer.cpp:
(WebCore::GStreamerVideoCapturer::setSinkVideoFrameCallback):

Canonical link: https://commits.webkit.org/287333@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list