[webkit-changes] [WebKit/WebKit] 36df2c: [WebGPU] BindGroups with destroyed resources shoul...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 36df2c80190b88669bc1c38a663cb5368bb040cd
      https://github.com/WebKit/WebKit/commit/36df2c80190b88669bc1c38a663cb5368bb040cd
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-12-03 (Tue, 03 Dec 2024)

  Changed paths:
    A LayoutTests/fast/webgpu/nocrash/fuzz-283943-expected.txt
    A LayoutTests/fast/webgpu/nocrash/fuzz-283943.html
    M Source/WebGPU/WebGPU/BindGroup.h
    M Source/WebGPU/WebGPU/BindGroup.mm
    M Source/WebGPU/WebGPU/ComputePassEncoder.mm
    M Source/WebGPU/WebGPU/RenderBundle.h
    M Source/WebGPU/WebGPU/RenderBundle.mm
    M Source/WebGPU/WebGPU/RenderBundleEncoder.h
    M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
    M Source/WebGPU/WebGPU/RenderPassEncoder.mm

  Log Message:
  -----------
  [WebGPU] BindGroups with destroyed resources should result in dropping the command buffer submission
https://bugs.webkit.org/show_bug.cgi?id=283943
rdar://140802614

Reviewed by Dan Glastonbury.

Bind groups are supposed to successfully be created, without validation error and resulting
in a valid bind group, even when the resources contained within the bind group are destroyed.

However, submitting any work to the driver via GPUQueue.submit(...) should still result in
a validation error at that time when the bind group contains a destroyed resource.

* LayoutTests/fast/webgpu/nocrash/fuzz-283943-expected.txt: Added.
* LayoutTests/fast/webgpu/nocrash/fuzz-283943.html: Added.
Add regression tests.

* Source/WebGPU/WebGPU/BindGroup.h:
* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::Device::createBindGroup):
(WebGPU::BindGroup::makeSubmitInvalid const):
* Source/WebGPU/WebGPU/ComputePassEncoder.mm:
(WebGPU::ComputePassEncoder::executePreDispatchCommands):
* Source/WebGPU/WebGPU/RenderBundle.h:
(WebGPU::RenderBundle::create):
* Source/WebGPU/WebGPU/RenderBundle.mm:
(WebGPU::RenderBundle::RenderBundle):
(WebGPU::m_makeSubmitInvalid):
(WebGPU::RenderBundle::makeSubmitInvalid const):
(WebGPU::m_commandCount): Deleted.
* Source/WebGPU/WebGPU/RenderBundleEncoder.h:
* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::RenderBundleEncoder::executePreDrawCommands):
(WebGPU::RenderBundleEncoder::finish):
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::executePreDrawCommands):
(WebGPU::RenderPassEncoder::executeBundles):

Canonical link: https://commits.webkit.org/287331@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications