[webkit-changes] [WebKit/WebKit] a81e01: [block-step-sizing] Add stubs for adjusting paddin...

[Sammy Gill]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a81e0173e5704bb9984e2f2b45f02f4462dbb3b3
      https://github.com/WebKit/WebKit/commit/a81e0173e5704bb9984e2f2b45f02f4462dbb3b3
  Author: Sammy Gill <sammy.gill at apple.com>
  Date:   2024-12-03 (Tue, 03 Dec 2024)

  Changed paths:
    M Source/WebCore/rendering/RenderBlockFlow.cpp
    M Source/WebCore/rendering/RenderBlockFlow.h

  Log Message:
  -----------
  [block-step-sizing] Add stubs for adjusting padding and content areas.
https://bugs.webkit.org/show_bug.cgi?id=283953
rdar://140825557

Reviewed by Tim Nguyen.

This is a refactoring that adds some stub functions aimed at helping
indicate which type of adjustments we currently support for
block-step-sizing. Adjustments to the margins are currently supported
while changes to the padding and content area still need to be
implemented.

1.) Move the code that handles block step sizing from
RenderBlockFlow::layoutBlockChild to a dedicated performBlockStepSizing
method so we do not pollute layoutBlockChild.
2.) perfromBlockStepSizing will call into the appropriate helper
function after computing the extra space to distribute it based on
block-step-insert

We will also put these helper functions into their own namespace to
organize them better and makes the naming less awkward (don't need to
shove BlockStepSizing into the naming somehow).

* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::BlockStepSizing::computeExtraSpace):
(WebCore::BlockStepSizing::distributeExtraSpaceToChildMargins):
(WebCore::BlockStepSizing::distributeExtraSpaceToChildPadding):
(WebCore::BlockStepSizing::distributeExtraSpaceToChildContentArea):
(WebCore::RenderBlockFlow::performBlockStepSizing const):
(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::computeExtraSpaceForBlockStepSizing): Deleted.
(WebCore::RenderBlockFlow::distributeExtraBlockStepSizingSpaceToChild const): Deleted.
* Source/WebCore/rendering/RenderBlockFlow.h:

Canonical link: https://commits.webkit.org/287315@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications