[webkit-changes] [WebKit/WebKit] 52a95a: BR styled clear is ignored while partially relayou...

Alan Baradlay noreply at github.com
Tue Dec 3 10:50:27 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 52a95a9a9640c7de601f772302ec4e7f1c0e6d12
      https://github.com/WebKit/WebKit/commit/52a95a9a9640c7de601f772302ec4e7f1c0e6d12
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-12-03 (Tue, 03 Dec 2024)

  Changed paths:
    A LayoutTests/fast/block/float/clear-followed-by-empty-content-expected.html
    A LayoutTests/fast/block/float/clear-followed-by-empty-content.html
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp

  Log Message:
  -----------
  BR styled clear is ignored while partially relayouting
https://bugs.webkit.org/show_bug.cgi?id=283859#
<rdar://problem/140734847>

Reviewed by Antti Koivisto.

We end up producing 2 'last' lines which confuses the 'clear' gap computation.

e.g. some content<br><span></span>

The first (and correct) 'last' line is "some content<br>" while we also mark the
trailing (and completely collapsed) "<span></span>" content as last line (even though this content does not generate any display content).

* LayoutTests/fast/block/float/clear-followed-by-empty-content-expected.html: Added.
* LayoutTests/fast/block/float/clear-followed-by-empty-content.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::isLastLineWithInlineContent const):

Canonical link: https://commits.webkit.org/287290@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list