[webkit-changes] [WebKit/WebKit] 3860dd: [JSC] MarkedBlock::dumpInfoAndCrashForInvalid: rec...

[Dan Hecht]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3860ddf416f4e59b4784998564c80284a78ca88e
      https://github.com/WebKit/WebKit/commit/3860ddf416f4e59b4784998564c80284a78ca88e
  Author: Dan Hecht <dan.hecht at apple.com>
  Date:   2024-12-03 (Tue, 03 Dec 2024)

  Changed paths:
    M Source/JavaScriptCore/heap/Heap.cpp
    M Source/JavaScriptCore/heap/MarkedBlock.cpp
    M Source/JavaScriptCore/heap/Subspace.h

  Log Message:
  -----------
  [JSC] MarkedBlock::dumpInfoAndCrashForInvalid: record subspace hash
https://bugs.webkit.org/show_bug.cgi?id=283328
rdar://140155909

Reviewed by Yijia Huang.

Record which SubSpace had the zeroed MarkedBlock header.
Maybe there will be a pattern.

Note that we reuse the register that had been used to save
the MarkedBlock pointer, since the MarkedBlock address is
the page address of the heapCell, which is recorded in another
register.

Also, fix up some SubSpace hash comments that seem to be stale.

* Source/JavaScriptCore/heap/Heap.cpp:
(JSC::Heap::Heap):
* Source/JavaScriptCore/heap/MarkedBlock.cpp:
(JSC::MarkedBlock::setupTestForDumpInfoAndCrash):
(JSC::MarkedBlock::dumpInfoAndCrashForInvalidHandleV2):
* Source/JavaScriptCore/heap/Subspace.h:
(JSC::Subspace::nameHash const):

Canonical link: https://commits.webkit.org/287271@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications