[webkit-changes] [WebKit/WebKit] fd33a1: [GStreamer][LibWebRTC] A/V sync issues

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fd33a1d498206af901c3d5337a59da1d2a7602bd
      https://github.com/WebKit/WebKit/commit/fd33a1d498206af901c3d5337a59da1d2a7602bd
  Author: Philippe Normand <philn at igalia.com>
  Date:   2024-12-03 (Tue, 03 Dec 2024)

  Changed paths:
    M Source/WebCore/platform/mediastream/gstreamer/GStreamerAudioCapturer.cpp
    M Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoFrameLibWebRTC.cpp
    M Source/WebCore/platform/mediastream/libwebrtc/gstreamer/RealtimeIncomingAudioSourceLibWebRTC.cpp
    M Source/WebCore/platform/mediastream/libwebrtc/gstreamer/RealtimeIncomingAudioSourceLibWebRTC.h
    M Source/WebCore/platform/mediastream/libwebrtc/gstreamer/RealtimeIncomingVideoSourceLibWebRTC.cpp

  Log Message:
  -----------
  [GStreamer][LibWebRTC] A/V sync issues
https://bugs.webkit.org/show_bug.cgi?id=283896

Reviewed by Xabier Rodriguez-Calvar.

Since the pipeline now synchronize on the system clock the timestamps for incoming audio/video
buffers should be based on that time. It was the case for video already (though with incorrect
units) and for audio we now apply a static base time base on the monotonic time.

LibWebRTC ifdefs were also removed from the audio capturer because they were leading to a caps
mismatch on the generated samples.

* Source/WebCore/platform/mediastream/gstreamer/GStreamerAudioCapturer.cpp:
(WebCore::GStreamerAudioCapturer::GStreamerAudioCapturer):
* Source/WebCore/platform/mediastream/libwebrtc/gstreamer/GStreamerVideoFrameLibWebRTC.cpp:
(WebCore::convertLibWebRTCVideoFrameToGStreamerSample):
* Source/WebCore/platform/mediastream/libwebrtc/gstreamer/RealtimeIncomingAudioSourceLibWebRTC.cpp:
(WebCore::RealtimeIncomingAudioSourceLibWebRTC::OnData):
* Source/WebCore/platform/mediastream/libwebrtc/gstreamer/RealtimeIncomingAudioSourceLibWebRTC.h:
* Source/WebCore/platform/mediastream/libwebrtc/gstreamer/RealtimeIncomingVideoSourceLibWebRTC.cpp:
(WebCore::RealtimeIncomingVideoSourceLibWebRTC::OnFrame):

Canonical link: https://commits.webkit.org/287268@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications