[webkit-changes] [WebKit/WebKit] e21746: [JSC] Should replace SameValue with CompareStrictE...

[Yijia Huang]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e21746365a842fb9992dc96b519defb6e2a51f4d
      https://github.com/WebKit/WebKit/commit/e21746365a842fb9992dc96b519defb6e2a51f4d
  Author: Yijia Huang <hyjorc1 at gmail.com>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M Source/JavaScriptCore/dfg/DFGStrengthReductionPhase.cpp

  Log Message:
  -----------
  [JSC] Should replace SameValue with CompareStrictEq since it cannot handle BooleanUse and Int32Use
https://bugs.webkit.org/show_bug.cgi?id=283937
rdar://140477242

Reviewed by Yusuke Suzuki.

SameValue cannot handle BooleanUse and Int32Use edges. So, the
optimization in the DFGStrengthReductionPhase for SameValue is
wrong. To fix that, we should convert SameValue to CompareStrictEq
since both of them have the same semantics for BooleanUse and Int32Use
and CompareStrictEq has the correct handle for those two use kinds.

* Source/JavaScriptCore/dfg/DFGStrengthReductionPhase.cpp:
(JSC::DFG::StrengthReductionPhase::handleNode):

Canonical link: https://commits.webkit.org/287261@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications