[webkit-changes] [WebKit/WebKit] 395507: Hovered link text not highlighted outside of bound...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 395507eacec43d64ef8ce04a92631a7d989837ca
      https://github.com/WebKit/WebKit/commit/395507eacec43d64ef8ce04a92631a7d989837ca
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    A LayoutTests/fast/repaint/glyph-horizontal-overflow-repaint-expected.txt
    A LayoutTests/fast/repaint/glyph-horizontal-overflow-repaint.html
    M LayoutTests/platform/mac/fast/text/text-letter-spacing-expected.txt
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp
    M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.h

  Log Message:
  -----------
  Hovered link text not highlighted outside of bounding box
https://bugs.webkit.org/show_bug.cgi?id=283861
<rdar://problem/140739413>

Reviewed by Antti Koivisto.

Add support for horizontal glyph overflow.

Make TextUtil::enclosingGlyphBounds return both ascent/descent and horizontal overflow.
(FIXME: With complex codepath, we may need to go through (measure) the entire content
and not just he first/last characters).

* LayoutTests/fast/repaint/glyph-horizontal-overflow-repaint-expected.txt: Added.
* LayoutTests/fast/repaint/glyph-horizontal-overflow-repaint.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
(WebCore::Layout::LineBoxBuilder::adjustInlineBoxHeightsForLineBoxContainIfApplicable):
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::appendTextDisplayBox):
* Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:
(WebCore::Layout::enclosingGlyphBoundsForRunWithIterator):
(WebCore::Layout::TextUtil::enclosingGlyphBounds):
(WebCore::Layout::TextUtil::enclosingGlyphBoundsForText): Deleted.
* Source/WebCore/layout/formattingContexts/inline/text/TextUtil.h:

text-letter-spacing: progression, still not 100% correct though.
Canonical link: https://commits.webkit.org/287256@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications