[webkit-changes] [WebKit/WebKit] f18bcc: Reduce the size of bmalloc_heap_inlines.h (v2)

[Simon Fraser]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f18bcc6525113a17806bea885d9a936bc431b9ed
      https://github.com/WebKit/WebKit/commit/f18bcc6525113a17806bea885d9a936bc431b9ed
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M Source/bmalloc/bmalloc.xcodeproj/project.pbxproj
    M Source/bmalloc/bmalloc/IsoHeap.cpp
    M Source/bmalloc/bmalloc/TZoneHeap.cpp
    M Source/bmalloc/libpas/src/libpas/bmalloc_heap.c
    M Source/bmalloc/libpas/src/libpas/bmalloc_heap_inlines.h
    A Source/bmalloc/libpas/src/libpas/bmalloc_heap_internal.h

  Log Message:
  -----------
  Reduce the size of bmalloc_heap_inlines.h (v2)
https://bugs.webkit.org/show_bug.cgi?id=283926
rdar://140803289

Reviewed by Mark Lam.

bmalloc_heap_inlines.h is the single most expensive header in WebKit, taking about 2.3s to parse in every compilation
unit which includes it (which is most of them).

bmalloc_heap_inlines.h also has some functions declared in it which are internal to bmalloc, so move those to
a new bmalloc_heap_internal.h header, which is included from the few bmalloc cpp files that need it.

* Source/bmalloc/bmalloc.xcodeproj/project.pbxproj:
* Source/bmalloc/bmalloc/IsoHeap.cpp:
* Source/bmalloc/bmalloc/TZoneHeap.cpp:
* Source/bmalloc/libpas/src/libpas/bmalloc_heap.c:
* Source/bmalloc/libpas/src/libpas/bmalloc_heap_inlines.h:
(bmalloc_try_iso_allocate_inline): Deleted.
(bmalloc_iso_allocate_inline): Deleted.
(bmalloc_try_iso_allocate_array_by_size_inline): Deleted.
(bmalloc_try_iso_allocate_zeroed_array_by_size_inline): Deleted.
(bmalloc_try_iso_allocate_array_by_size_with_alignment_inline): Deleted.
(bmalloc_try_iso_allocate_array_by_count_inline): Deleted.
(bmalloc_try_iso_allocate_array_by_count_with_alignment_inline): Deleted.
(bmalloc_iso_allocate_array_by_size_inline): Deleted.
(bmalloc_iso_allocate_zeroed_array_by_size_inline): Deleted.
(bmalloc_iso_allocate_array_by_size_with_alignment_inline): Deleted.
(bmalloc_iso_allocate_array_by_count_inline): Deleted.
(bmalloc_iso_allocate_array_by_count_with_alignment_inline): Deleted.
(bmalloc_try_iso_reallocate_array_by_size_inline): Deleted.
(bmalloc_iso_reallocate_array_by_size_inline): Deleted.
(bmalloc_try_iso_reallocate_array_by_count_inline): Deleted.
(bmalloc_iso_reallocate_array_by_count_inline): Deleted.
(bmalloc_try_allocate_flex_inline): Deleted.
(bmalloc_allocate_flex_inline): Deleted.
(bmalloc_try_allocate_zeroed_flex_inline): Deleted.
(bmalloc_allocate_zeroed_flex_inline): Deleted.
(bmalloc_try_allocate_flex_with_alignment_inline): Deleted.
(bmalloc_allocate_flex_with_alignment_inline): Deleted.
(bmalloc_try_reallocate_flex_inline): Deleted.
(bmalloc_reallocate_flex_inline): Deleted.
* Source/bmalloc/libpas/src/libpas/bmalloc_heap_internal.h: Copied from Source/bmalloc/libpas/src/libpas/bmalloc_heap_inlines.h.
(bmalloc_try_iso_allocate_inline):
(bmalloc_iso_allocate_inline):
(bmalloc_try_iso_allocate_array_by_size_inline):
(bmalloc_try_iso_allocate_zeroed_array_by_size_inline):
(bmalloc_try_iso_allocate_array_by_size_with_alignment_inline):
(bmalloc_try_iso_allocate_array_by_count_inline):
(bmalloc_try_iso_allocate_array_by_count_with_alignment_inline):
(bmalloc_iso_allocate_array_by_size_inline):
(bmalloc_iso_allocate_zeroed_array_by_size_inline):
(bmalloc_iso_allocate_array_by_size_with_alignment_inline):
(bmalloc_iso_allocate_array_by_count_inline):
(bmalloc_iso_allocate_array_by_count_with_alignment_inline):
(bmalloc_try_iso_reallocate_array_by_size_inline):
(bmalloc_iso_reallocate_array_by_size_inline):
(bmalloc_try_iso_reallocate_array_by_count_inline):
(bmalloc_iso_reallocate_array_by_count_inline):
(bmalloc_try_allocate_flex_inline):
(bmalloc_allocate_flex_inline):
(bmalloc_try_allocate_zeroed_flex_inline):
(bmalloc_allocate_zeroed_flex_inline):
(bmalloc_try_allocate_flex_with_alignment_inline):
(bmalloc_allocate_flex_with_alignment_inline):
(bmalloc_try_reallocate_flex_inline):
(bmalloc_reallocate_flex_inline):

Canonical link: https://commits.webkit.org/287252@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications