[webkit-changes] [WebKit/WebKit] 60a5f0: REGRESSION(285421 at main): Crash when restoring sess...

[Charlie Wolfe]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 60a5f04e58e1d262e0593783bc7592f9d5dd0b8b
      https://github.com/WebKit/WebKit/commit/60a5f04e58e1d262e0593783bc7592f9d5dd0b8b
  Author: Charlie Wolfe <charliew at apple.com>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M Source/WebKit/UIProcess/WebBackForwardList.cpp
    M Tools/TestWebKitAPI/Tests/WebKit/WKBackForwardListTests.mm

  Log Message:
  -----------
  REGRESSION(285421 at main): Crash when restoring session state while a provisional history item is set
https://bugs.webkit.org/show_bug.cgi?id=283924
rdar://140463108

Reviewed by Wenson Hsieh.

When session state is restored, the current history item index is updated, but the provisional index is
not cleared. So, if a provisional index was set before the session was restored, it will be stale and
point to an index that is incorrect or out-of-bounds `m_entries`.

* Source/WebKit/UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::restoreFromState):
* Tools/TestWebKitAPI/Tests/WebKit/WKBackForwardListTests.mm:
(TEST(WKBackForwardList, RestoreSessionStateResetProvisionalItem)):

Canonical link: https://commits.webkit.org/287248@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications