[webkit-changes] [WebKit/WebKit] 550807: Remove _WKWebExtensionLocalization.

[Timothy Hatcher]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 550807bc4946c585b1e1a5e0a2f788deb98c9817
      https://github.com/WebKit/WebKit/commit/550807bc4946c585b1e1a5e0a2f788deb98c9817
  Author: Timothy Hatcher <timothy at apple.com>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M Source/WebKit/Shared/Extensions/WebExtensionContextParameters.h
    M Source/WebKit/Shared/Extensions/WebExtensionContextParameters.serialization.in
    M Source/WebKit/Shared/Extensions/WebExtensionLocalization.cpp
    R Source/WebKit/Shared/Extensions/_WKWebExtensionLocalization.h
    R Source/WebKit/Shared/Extensions/_WKWebExtensionLocalization.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebExtension.mm
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm
    M Source/WebKit/UIProcess/Extensions/WebExtension.cpp
    M Source/WebKit/UIProcess/Extensions/WebExtension.h
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKit/WebProcess/Extensions/Cocoa/WebExtensionContextProxyCocoa.mm

  Log Message:
  -----------
  Remove _WKWebExtensionLocalization.
https://webkit.org/b/283935
rdar://problem/140811081

Reviewed by Brian Weinstein.

We can remove _WKWebExtensionLocalization now that is it implemented as WebKit::WebExtensionLocalization.
This allows us to drop the NSDictionary copy of the manifest as well, and just generate it when needed for
the last remaining Cocoa manifest dNR parsing and Cocoa API.

* Source/WebKit/Shared/Extensions/WebExtensionContextParameters.h:
* Source/WebKit/Shared/Extensions/WebExtensionContextParameters.serialization.in:
* Source/WebKit/Shared/Extensions/WebExtensionLocalization.cpp:
(WebKit::WebExtensionLocalization::localizationJSONForWebExtension):
* Source/WebKit/Shared/Extensions/_WKWebExtensionLocalization.h: Removed.
* Source/WebKit/Shared/Extensions/_WKWebExtensionLocalization.mm: Removed.
* Source/WebKit/UIProcess/API/Cocoa/WKWebExtension.mm:
(-[WKWebExtension manifest]):
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm:
(WebKit::WebExtension::manifestDictionary): Renamed from manifest().
(WebKit::WebExtension::populateDeclarativeNetRequestPropertiesIfNeeded):
(WebKit::WebExtension::parseManifest): Deleted.
(WebKit::WebExtension::manifest): Deleted.
(WebKit::WebExtension::serializeManifest): Deleted.
* Source/WebKit/UIProcess/Extensions/WebExtension.cpp:
(WebKit::WebExtension::WebExtension):
(WebKit::WebExtension::parseManifest):
(WebKit::WebExtension::manifestObject):
(WebKit::WebExtension::manifestParsedSuccessfully):
(WebKit::WebExtension::serializeManifest):
* Source/WebKit/UIProcess/Extensions/WebExtension.h:
(WebKit::WebExtension::manifestObject): Deleted.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/Extensions/Cocoa/WebExtensionContextProxyCocoa.mm:
(WebKit::WebExtensionContextProxy::getOrCreate):

Canonical link: https://commits.webkit.org/287238@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications