[webkit-changes] [WebKit/WebKit] ee9eea: [ews-build] Add steps to support filtering safer-c...

Brianna Fan noreply at github.com
Mon Dec 2 12:48:19 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ee9eeaa4c7f099c8ad6cc1f8ddbfe87346545d46
      https://github.com/WebKit/WebKit/commit/ee9eeaa4c7f099c8ad6cc1f8ddbfe87346545d46
  Author: Brianna Fan <bfan2 at apple.com>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M Tools/CISupport/ews-build/steps.py
    M Tools/CISupport/ews-build/steps_unittest.py

  Log Message:
  -----------
  [ews-build] Add steps to support filtering safer-cpp-results with results.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=283064
rdar://139814797

Reviewed by Jonathan Bedard.

These steps are needed after filtering safer-cpp-checks results using results database.
The buildbot master will filter results and modify unexpected_results.json file, so the
worker will need the updated file through DownloadUnexpectedResultsFromMaster.

With the updated results, we will need to re-generate the results index page using
GenerateSaferCPPResultsIndex.

Then, we want to delete full StaticAnalyzer results so they're not uploaded to
the master by using DeleteStaticAnalyzerResults.

(DownloadUnexpectedResultsFromMaster):
    - If results database filters out results, we need to move the new unexpected_results.json file
      over to the worker from the master.
    - This uses the pre-existing transfer.FileDownload step and is similar to DownloadBuiltProductFromMaster.

(DeleteStaticAnalyzerResults):
    - Added if there are unexpected results. We don't want to upload the entire 40GB+ results so
      this step deletes the specified StaticAnalyzer directory.

(GenerateSaferCPPResultsIndex):
    - If there are unexpected results after filtering, we need to generate a new results index page
      that displays the results with links to each report.
    - This is run on the worker and uses the unexpected_results.json file from DownloadUnexpectedResultsFromMaster.
    - It also sets the 'unexpected_new_issues' property to be used by DisplaySaferCPPResults.

* Tools/CISupport/ews-build/steps_unittest.py: Added unittests for DownloadUnexpectedResultsFromMaster,
    DeleteStaticAnalyzerResults, and GenerateSaferCPPResultsIndex.

Canonical link: https://commits.webkit.org/287229@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list