[webkit-changes] [WebKit/WebKit] 8dd79f: Stop WebExtensionLocalization from modifying the o...

[Jamie Murphy]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8dd79f91f9c8ba584358ea164bd62cf5b32d476f
      https://github.com/WebKit/WebKit/commit/8dd79f91f9c8ba584358ea164bd62cf5b32d476f
  Author: Jamie Murphy <hello at itsjamie.dev>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M Source/WebKit/Shared/Extensions/WebExtensionLocalization.cpp
    M Source/WebKit/Shared/Extensions/WebExtensionLocalization.h
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm

  Log Message:
  -----------
  Stop WebExtensionLocalization from modifying the original input
https://webkit.org/b/283884

Reviewed by Timothy Hatcher.

The localizedJSONforJSON and localizedArrayForArray shouldn't modify the original input,
and instead should return a modified copy of the input to keep parity with the original
Cocoa functions.

* Source/WebKit/Shared/Extensions/WebExtensionLocalization.cpp:
(WebKit::WebExtensionLocalization::localizedJSONforJSON):
(WebKit::WebExtensionLocalization::localizedArrayForArray):
* Source/WebKit/Shared/Extensions/WebExtensionLocalization.h:
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm:
(WebKit::WebExtension::parseManifest):

Canonical link: https://commits.webkit.org/287225@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications