[webkit-changes] [WebKit/WebKit] 22f1a2: Expose `WKPreferences/tabFocusesLinks` internally ...

Richard Robinson noreply at github.com
Mon Dec 2 08:20:57 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 22f1a23dde6d414c7c6e860d970cc3f8e038178a
      https://github.com/WebKit/WebKit/commit/22f1a23dde6d414c7c6e860d970cc3f8e038178a
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2024-12-02 (Mon, 02 Dec 2024)

  Changed paths:
    M Source/WebCore/page/EventHandler.cpp
    M Source/WebCore/page/ios/EventHandlerIOS.mm
    M Source/WebCore/page/mac/EventHandlerMac.mm
    M Source/WebKit/Modules/Internal/WebKitInternal.h
    M Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKPreferencesInternal.h
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/Coding.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/Copying.mm

  Log Message:
  -----------
  Expose `WKPreferences/tabFocusesLinks` internally on iOS
https://bugs.webkit.org/show_bug.cgi?id=283651
rdar://140508437

Reviewed by Wenson Hsieh.

The logic for having the tab key switch focus to forms and links is already platform-agnostic, so this
just exposes it for iOS.

Also de-duplicate some code.

* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::tabsToAllFormControls const):
* Source/WebCore/page/ios/EventHandlerIOS.mm:
(WebCore::EventHandler::tabsToAllFormControls const): Deleted.
* Source/WebCore/page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::tabsToAllFormControls const): Deleted.
* Source/WebKit/Modules/Internal/WebKitInternal.h:
* Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences encodeWithCoder:]):
(-[WKPreferences initWithCoder:]):
* Source/WebKit/UIProcess/API/Cocoa/WKPreferencesInternal.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
(TEST(Coding, WKPreferences)):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/Copying.mm:
(TEST(Copying, WKPreferences)):

Canonical link: https://commits.webkit.org/287221@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list