[webkit-changes] [WebKit/WebKit] f5fb01: REGRESSION (276312 at main): EventHandler::handleWhee...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f5fb0119fb8192fa04ff67374e1e3ea1c45abb36
      https://github.com/WebKit/WebKit/commit/f5fb0119fb8192fa04ff67374e1e3ea1c45abb36
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2024-12-01 (Sun, 01 Dec 2024)

  Changed paths:
    M Source/WebCore/page/EventHandler.cpp
    M Source/WebCore/page/WheelEventTestMonitor.h

  Log Message:
  -----------
  REGRESSION (276312 at main): EventHandler::handleWheelEventInternal no longer defers scroll wheel event handling completion
https://bugs.webkit.org/show_bug.cgi?id=283860

Reviewed by Alan Baradlay.

276312 at main appears to have unintentionally changed the scope of the RAII deferrer in this method,
such that it adds and then immediately removes a deferral reason (instead of lasting through the
scope of the method itself). Restore the previous behavior, by pulling this out into a `unique_ptr`
that's set only if `scrollableArea` is nonnull.

* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::handleWheelEventInternal):
* Source/WebCore/page/WheelEventTestMonitor.h:

Canonical link: https://commits.webkit.org/287192@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications