[webkit-changes] [WebKit/WebKit] 030cac: AX: Various AccessibilityObject and AXObjectCache ...

[Tyler Wilcock]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 030cac1847daa66c0b4e1404deeee8f15c61d6ac
      https://github.com/WebKit/WebKit/commit/030cac1847daa66c0b4e1404deeee8f15c61d6ac
  Author: Tyler Wilcock <tyler_w at apple.com>
  Date:   2024-08-31 (Sat, 31 Aug 2024)

  Changed paths:
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AXObjectCache.h
    M Source/WebCore/accessibility/AXTextMarker.cpp
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
    M Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp
    M Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm
    M Source/WebCore/accessibility/mac/AXObjectCacheMac.mm
    M Source/WebCore/accessibility/playstation/AXObjectCachePlayStation.cpp
    M Source/WebCore/accessibility/win/AXObjectCacheWin.cpp
    M Source/WebCore/page/LocalFrameView.cpp

  Log Message:
  -----------
  AX: Various AccessibilityObject and AXObjectCache helper methods take Node* or RenderObject* when they could take a reference
https://bugs.webkit.org/show_bug.cgi?id=278956
rdar://135063206

Reviewed by Chris Fleizach.

In all callsites of these functions that take Node* or RenderObject*, we know from the context that the passed pointer
cannot be null (e.g. because we already checked), meaning we're performing unnecessary null-checks:

  - recomputeIsIgnored(RenderObject*)
  - replacedNodeNeedsCharacter(Node*)
  - isReplacedNodeOrBR(Node* node)
  - handleScrolledToAnchor(const Node*)
  - nodeHasPresentationRole(Node*)
  - isModalDescendant(Node*)

* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::recomputeIsIgnored):
(WebCore::AXObjectCache::traverseToOffsetInRange):
(WebCore::AXObjectCache::lengthForRange):
(WebCore::AXObjectCache::rangeForNodeContents):
(WebCore::isReplacedNodeOrBR):
(WebCore::characterOffsetsInOrder):
(WebCore::boundaryPoint):
(WebCore::AXObjectCache::nextCharacterOffset):
(WebCore::AXObjectCache::previousBoundary):
(WebCore::AXObjectCache::performDeferredCacheUpdate):
(WebCore::AXObjectCache::deferRecomputeIsIgnoredIfNeeded):
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AXTextMarker.cpp:
(WebCore::AXTextMarker::boundaryPoint const):
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::replacedNodeNeedsCharacter):
(WebCore::AccessibilityObject::stringForRange const):
(WebCore::AccessibilityObject::stringForVisiblePositionRange):
(WebCore::AccessibilityObject::isModalDescendant const):
(WebCore::AccessibilityObject::ignoredFromModalPresence const):
(WebCore::nodeHasPresentationRole):
(WebCore::AccessibilityObject::supportsPressAction const):
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::webAreaIsPresentational):
* Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp:
(WebCore::AXObjectCache::handleScrolledToAnchor):
* Source/WebCore/accessibility/ios/AXObjectCacheIOS.mm:
(WebCore::AXObjectCache::handleScrolledToAnchor):
* Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::handleScrolledToAnchor):
* Source/WebCore/accessibility/playstation/AXObjectCachePlayStation.cpp:
(WebCore::AXObjectCache::handleScrolledToAnchor):
* Source/WebCore/accessibility/win/AXObjectCacheWin.cpp:
(WebCore::AXObjectCache::handleScrolledToAnchor):
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::scrollToAnchor):

Canonical link: https://commits.webkit.org/283031@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications