[webkit-changes] [WebKit/WebKit] 39dc84: Begin integrating WebAuthn with LoginStatus API

Commit Queue noreply at github.com
Sat Aug 31 10:06:53 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 39dc84ffd6e37c66dfed5af48c013ee4561bab93
      https://github.com/WebKit/WebKit/commit/39dc84ffd6e37c66dfed5af48c013ee4561bab93
  Author: Pouneh Bahrami <pnikkhah at ucdavis.edu>
  Date:   2024-08-31 (Sat, 31 Aug 2024)

  Changed paths:
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp
    M Source/WebCore/page/LoginStatus.cpp
    M Source/WebCore/page/LoginStatus.h
    M Source/WebCore/page/Page.cpp
    M Source/WebCore/page/Page.h
    M Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp
    M Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Tools/TestWebKitAPI/Tests/WebCore/LoginStatus.cpp

  Log Message:
  -----------
  Begin integrating WebAuthn with LoginStatus API
https://bugs.webkit.org/show_bug.cgi?id=277359
rdar://132824596

Reviewed by Charlie Wolfe, Chris Dumez, and Pascoe.

We integrate the WebAuthn with LoginStatus API. So setting a status is now conditional to logging in using WebAuthn in 30s.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/Modules/webauthn/AuthenticatorCoordinator.cpp:
(WebCore::AuthenticatorCoordinator::discoverFromExternalSource):
* Source/WebCore/page/LoginStatus.cpp:
(WebCore::LoginStatus::LoginStatus):
* Source/WebCore/page/LoginStatus.h:
(WebCore::LoginStatus::domain const):
(WebCore::LoginStatus::tokenType const):
(WebCore::LoginStatus::authType const):
(WebCore::LoginStatus::timeToLive const):
(WebCore::LoginStatus::registrableDomain const): Deleted.
(WebCore::LoginStatus::credentialTokenType const): Deleted.
(WebCore::LoginStatus::authenticationType const): Deleted.
* Source/WebCore/page/Page.cpp:
(WebCore::Page::setLastAuthentication):
* Source/WebCore/page/Page.h:
(WebCore::Page::lastAuthentication const):
* Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::setLoginStatus):
(WebKit::WebResourceLoadStatisticsStore::isLoggedIn):
* Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::setLoginStatus):
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
(WebKit::NetworkConnectionToWebProcess::isLoginStatusAPIRequiresWebAuthnEnabled const):
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setLoginStatus):
* Tools/TestWebKitAPI/Tests/WebCore/LoginStatus.cpp:
(TestWebKitAPI::TEST(LoginStatus, DefaultExpiryWebAuthn)):
(TestWebKitAPI::TEST(LoginStatus, DefaultExpiryPasswordManager)):
(TestWebKitAPI::TEST(LoginStatus, DefaultExpiryUnmanaged)):
(TestWebKitAPI::TEST(LoginStatus, CustomExpiryBelowLong)):
(TestWebKitAPI::TEST(LoginStatus, CustomExpiryBelowShort)):
(TestWebKitAPI::TEST(LoginStatus, RenewedExpiry)):
(TestWebKitAPI::TEST(LoginStatus, ClampedExpiryLong)):
(TestWebKitAPI::TEST(LoginStatus, ClampedExpiryShort)):

Canonical link: https://commits.webkit.org/283025@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list