[webkit-changes] [WebKit/WebKit] 42aed7: Use smart pointer when accessing BackForwardContro...

[Rob Buis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 42aed7355cb1430dbe69c60fb5720f68a14e9f9b
      https://github.com/WebKit/WebKit/commit/42aed7355cb1430dbe69c60fb5720f68a14e9f9b
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2024-08-31 (Sat, 31 Aug 2024)

  Changed paths:
    M Source/WebCore/history/CachedPage.cpp
    M Source/WebCore/loader/FrameLoader.cpp
    M Source/WebCore/loader/HistoryController.cpp
    M Source/WebCore/loader/NavigationScheduler.cpp
    M Source/WebCore/page/ContextMenuController.cpp
    M Source/WebCore/page/DOMWindow.cpp
    M Source/WebCore/page/EventHandler.cpp
    M Source/WebCore/page/History.cpp
    M Source/WebCore/page/Page.h
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm
    M Source/WebKitLegacy/mac/WebView/WebView.mm

  Log Message:
  -----------
  Use smart pointer when accessing BackForwardController
https://bugs.webkit.org/show_bug.cgi?id=278017

Reviewed by Ryosuke Niwa.

Use smart pointer when accessing BackForwardController
based on [alpha.webkit.UncountedCallArgsChecker] warnings.

Note that most methods in BackForwardController are not trivial
since they delegate to the client, which likely ends up sending
IPC messages.

* Source/WebCore/history/CachedPage.cpp:
(WebCore::CachedPage::restore):
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::updateNavigationAPIEntries):
* Source/WebCore/loader/HistoryController.cpp:
(WebCore::HistoryController::goToItem):
(WebCore::HistoryController::updateBackForwardListClippedAtTarget):
(WebCore::HistoryController::pushState):
* Source/WebCore/loader/NavigationScheduler.cpp:
(WebCore::NavigationScheduler::scheduleHistoryNavigation):
* Source/WebCore/page/ContextMenuController.cpp:
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::checkOrEnableIfNeeded const):
* Source/WebCore/page/DOMWindow.cpp:
(WebCore::DOMWindow::close):
* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::defaultBackspaceEventHandler):
* Source/WebCore/page/History.cpp:
(WebCore::History::length const):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::dumpHistoryForTesting):
* Source/WebCore/page/Page.h:
* Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performNonEditingBehaviorForSelector):
* Source/WebKitLegacy/mac/WebView/WebView.mm:
(-[WebView _loadBackForwardListFromOtherView:]):

Canonical link: https://commits.webkit.org/283019@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications