[webkit-changes] [WebKit/WebKit] 7662fa: [ MacOS x86_64 wk2 ] fast/webgpu/regression/repro_...

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7662fa7cb93963ffe4e0ab9fda31ad5614f80d43
      https://github.com/WebKit/WebKit/commit/7662fa7cb93963ffe4e0ab9fda31ad5614f80d43
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-08-30 (Fri, 30 Aug 2024)

  Changed paths:
    M LayoutTests/fast/webgpu/regression/repro_275111b.html
    M LayoutTests/platform/mac-wk2/TestExpectations
    M Source/WebGPU/WebGPU/Buffer.h
    M Source/WebGPU/WebGPU/Buffer.mm
    M Source/WebGPU/WebGPU/CommandBuffer.h
    M Source/WebGPU/WebGPU/CommandBuffer.mm
    M Source/WebGPU/WebGPU/CommandEncoder.h
    M Source/WebGPU/WebGPU/CommandEncoder.mm
    M Source/WebGPU/WebGPU/ComputePassEncoder.mm
    M Source/WebGPU/WebGPU/Device.h
    M Source/WebGPU/WebGPU/Device.mm
    M Source/WebGPU/WebGPU/MetalSPI.h
    M Source/WebGPU/WebGPU/PresentationContextIOSurface.mm
    M Source/WebGPU/WebGPU/Queue.h
    M Source/WebGPU/WebGPU/Queue.mm
    M Source/WebGPU/WebGPU/RenderPassEncoder.mm

  Log Message:
  -----------
  [ MacOS x86_64 wk2 ] fast/webgpu/regression/repro_275111b.html is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=275758
radar://130302752

Reviewed by Tadeu Zagallo.

Command buffers were collecting because we didn't remove
them in WebGPU::CommandBuffer's destructor.

With this change, we don't need the abort event which was
Apple Silicon only so we no longer sumbit invalid command buffers
on Intel Macs.

* LayoutTests/platform/mac-wk2/TestExpectations:
Remove failing test expectation.

* Source/WebGPU/WebGPU/CommandBuffer.h:
(WebGPU::CommandBuffer::create):
* Source/WebGPU/WebGPU/CommandBuffer.mm:
(WebGPU::CommandBuffer::CommandBuffer):
(WebGPU::CommandBuffer::~CommandBuffer):
(WebGPU::CommandBuffer::makeInvalid):
* Source/WebGPU/WebGPU/CommandEncoder.h:
(WebGPU::CommandEncoder::create):
* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::Device::createCommandEncoder):
(WebGPU::CommandEncoder::CommandEncoder):
(WebGPU::CommandEncoder::~CommandEncoder):
(WebGPU::CommandEncoder::discardCommandBuffer):
(WebGPU::CommandEncoder::endEncoding):
(WebGPU::CommandEncoder::makeInvalid):
(WebGPU::CommandEncoder::finish):
* Source/WebGPU/WebGPU/ComputePassEncoder.h:
* Source/WebGPU/WebGPU/ComputePassEncoder.mm:
(WebGPU::ComputePassEncoder::~ComputePassEncoder):
* Source/WebGPU/WebGPU/Device.h:
(WebGPU::Device::makeInvalid): Deleted.
* Source/WebGPU/WebGPU/Device.mm:
(WebGPU::Device::create):
Increase the limit since sometimes it takes time for the GC to
run.

(WebGPU::Device::makeInvalid):
(WebGPU::Device::loseTheDevice):
* Source/WebGPU/WebGPU/MetalSPI.h:
* Source/WebGPU/WebGPU/PresentationContextIOSurface.mm:
* Source/WebGPU/WebGPU/Queue.h:
* Source/WebGPU/WebGPU/Queue.mm:
(WebGPU::Queue::ensureBlitCommandEncoder):
(WebGPU::Queue::commandBufferWithDescriptor):
(WebGPU::Queue::makeInvalid):
(WebGPU::Queue::removeMTLCommandBuffer):
(WebGPU::Queue::removeMTLCommandBufferInternal):
(WebGPU::Queue::commitMTLCommandBuffer):
* Source/WebGPU/WebGPU/RenderPassEncoder.h:
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::~RenderPassEncoder):

Canonical link: https://commits.webkit.org/283015@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications