[webkit-changes] [WebKit/WebKit] 311f6e: [WebDriver] Add BiDi webSocketUrl capability

[Lauro Moura]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 311f6ee395f786e3285e1502a0935c40551f2777
      https://github.com/WebKit/WebKit/commit/311f6ee395f786e3285e1502a0935c40551f2777
  Author: Lauro Moura <lmoura at igalia.com>
  Date:   2024-08-30 (Fri, 30 Aug 2024)

  Changed paths:
    M Source/WebDriver/Capabilities.h
    M Source/WebDriver/WebDriverService.cpp
    M Source/WebDriver/WebDriverService.h
    M Source/WebDriver/glib/WebDriverServiceGLib.cpp
    M Source/WebDriver/playstation/WebDriverServicePlayStation.cpp
    M Source/WebDriver/win/WebDriverServiceWin.cpp

  Log Message:
  -----------
  [WebDriver] Add BiDi webSocketUrl capability
https://bugs.webkit.org/show_bug.cgi?id=278390

Reviewed by Carlos Garcia Campos.

This is a new capability defined by the Webdriver Bidi spec[1]. When the
user sends `webSocketUrl==true`, it means the user requested a BiDi
session in parallel to the classic session being initiated.

This commit adds support for parsing and processing webSocketURL, failing
the capability negotiation explictly if the user requested it and we don't
support BiDi, which is the case for now, instead of failing as a unknown
capability key in WebDriverService::validatedCapabilities().

bug230615 (BiDi session support) will build on top of this to make use of
this capability to actually setup BiDi sessions.

Note: The platformSupportBidi() definitions are already split among the
port-specific files, so each port can enable it individually.

[1] https://w3c.github.io/webdriver-bidi/#websocket-url

* Source/WebDriver/Capabilities.h:
* Source/WebDriver/WebDriverService.cpp:
(WebDriver::WebDriverService::parseCapabilities const):
(WebDriver::WebDriverService::validatedCapabilities const):
(WebDriver::WebDriverService::matchCapabilities const):
* Source/WebDriver/WebDriverService.h:
* Source/WebDriver/glib/WebDriverServiceGLib.cpp:
(WebDriver::WebDriverService::platformSupportBidi const):
* Source/WebDriver/playstation/WebDriverServicePlayStation.cpp:
(WebDriver::WebDriverService::platformSupportBidi const):
* Source/WebDriver/win/WebDriverServiceWin.cpp:
(WebDriver::WebDriverService::platformSupportBidi const):

Canonical link: https://commits.webkit.org/283007@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications