[webkit-changes] [WebKit/WebKit] 798529: [css-view-transitions-2] no-view-transition-with-c...

mattwoodrow noreply at github.com
Fri Aug 30 17:41:41 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 798529e297cf544acc9dcf47c849463e9ed22cf4
      https://github.com/WebKit/WebKit/commit/798529e297cf544acc9dcf47c849463e9ed22cf4
  Author: Matt Woodrow <mattwoodrow at apple.com>
  Date:   2024-08-30 (Fri, 30 Aug 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/navigation/no-view-transition-with-cross-origin-redirect.sub.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/navigation/pageswap-long-delay-expected.txt
    M Source/WebCore/loader/DocumentLoader.cpp

  Log Message:
  -----------
  [css-view-transitions-2] no-view-transition-with-cross-origin-redirect.sub.html fails.
https://bugs.webkit.org/show_bug.cgi?id=278837
<rdar://134908686>

Reviewed by Alex Christensen.

Cross-origin redirects should prevent the view transition from being allowed

This changes the test a bit, since 'hosts[][www]}' was resolving to
'www.localhost'. I'm not sure if that's a WebKit bug, or a test harness issue,
but using hosts[alt] should be a valid version of the test (where the initial
request is cross origin, but the post-redirect response is not).

It also moves the failure annotation for pageswap-long-delay.html into the
TestExpectations file, so that a URL to the spec issue can be added.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/navigation/no-view-transition-with-cross-origin-redirect.sub.html:
* LayoutTests/imported/w3c/web-platform-tests/css/css-view-transitions/navigation/pageswap-long-delay-expected.txt:
* Source/WebCore/loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::navigationCanTriggerCrossDocumentViewTransition):

Canonical link: https://commits.webkit.org/283004@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list