[webkit-changes] [WebKit/WebKit] 77b319: [Writing Tools] Tools should be supported even whe...

Aditya Keerthi noreply at github.com
Fri Aug 30 15:45:32 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 77b319164fe7efc8a58ddfd73e6ddf755758d5b7
      https://github.com/WebKit/WebKit/commit/77b319164fe7efc8a58ddfd73e6ddf755758d5b7
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2024-08-30 (Fri, 30 Aug 2024)

  Changed paths:
    M Source/WebCore/page/writing-tools/WritingToolsController.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm

  Log Message:
  -----------
  [Writing Tools] Tools should be supported even when there is no selection
https://bugs.webkit.org/show_bug.cgi?id=278940
rdar://135032816

Reviewed by Abrar Rahman Protyasha and Wenson Hsieh.

When there is no selection, Writing Tools should operate on the entire contents
of the document.

* Source/WebCore/page/writing-tools/WritingToolsController.mm:
(WebCore::contextRangeForSession):
(WebCore::WritingToolsController::willBeginWritingToolsSession):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm:
(TEST(WritingTools, ContextRangeWithNoSelection)):

Canonical link: https://commits.webkit.org/282997@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list