[webkit-changes] [WebKit/WebKit] 6f82e5: TestWebKitAPI.WebPushDBuiltInTest.ImplicitSilentPu...

Brady Eidson noreply at github.com
Fri Aug 30 15:32:19 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6f82e5b91c8b0bbdcaeccaaec881493739d21839
      https://github.com/WebKit/WebKit/commit/6f82e5b91c8b0bbdcaeccaaec881493739d21839
  Author: Brady Eidson <beidson at apple.com>
  Date:   2024-08-30 (Fri, 30 Aug 2024)

  Changed paths:
    M Source/WebKit/webpushd/_WKMockUserNotificationCenter.h
    M Source/WebKit/webpushd/_WKMockUserNotificationCenter.mm

  Log Message:
  -----------
  TestWebKitAPI.WebPushDBuiltInTest.ImplicitSilentPushTimerCancelledOnShowingNotification is a constant failure (due to webpushd crash)
https://bugs.webkit.org/show_bug.cgi?id=278931
rdar://134969476

Reviewed by Sihui Liu.

`webpushd` started using a new UNUserNotifcationCenter API that our _WKMockUserNotificationCenter object didn't implement.
Therefore it crashed due to a missing selector.
Stub it out to fix up the test.

* Source/WebKit/webpushd/_WKMockUserNotificationCenter.h:
* Source/WebKit/webpushd/_WKMockUserNotificationCenter.mm:
(-[_WKMockUserNotificationCenter setNotificationCategories:]):

Canonical link: https://commits.webkit.org/282994@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list