[webkit-changes] [WebKit/WebKit] 4f29c3: Invalidate table columns when a column span changes

[Andreu Botella]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4f29c3293f6e87e0b6fb0f8ceb91ce7005cd109c
      https://github.com/WebKit/WebKit/commit/4f29c3293f6e87e0b6fb0f8ceb91ce7005cd109c
  Author: Andreu Botella <abotella at igalia.com>
  Date:   2024-08-30 (Fri, 30 Aug 2024)

  Changed paths:
    M LayoutTests/imported/w3c/resources/resource-files.json
    A LayoutTests/imported/w3c/web-platform-tests/css/css-tables/paint/col-change-span-bg-invalidation-001-expected.xht
    A LayoutTests/imported/w3c/web-platform-tests/css/css-tables/paint/col-change-span-bg-invalidation-001.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-tables/paint/col-change-span-bg-invalidation-002-expected.xht
    A LayoutTests/imported/w3c/web-platform-tests/css/css-tables/paint/col-change-span-bg-invalidation-002.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-tables/paint/row-background-paint-remove-last-cell-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-tables/paint/row-background-paint-remove-last-cell-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-tables/paint/row-background-paint-remove-last-cell.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-tables/paint/w3c-import.log
    M Source/WebCore/rendering/RenderTableCol.cpp

  Log Message:
  -----------
  Invalidate table columns when a column span changes
https://bugs.webkit.org/show_bug.cgi?id=246321

Reviewed by Alan Baradlay.

A table column element (`RenderTableCol`) spans a number of actual
table columns, and that set of spanned columns can change when its
span attribute changes. However, when this happens, the table columns
are not currently being invalidated, which can result in the
background of the table columns not changing when it should.

This patch fixes that by invalidating the table columns when some
column's span changes, which will trigger a relayout and repaint of
the table.

This patch also incorporates the
`css/css-tables/paint/col-change-span-bg-invalidation-{001,002}.html`
WPT tests, which test that the column background is correctly updated.

Combined changes:
* LayoutTests/imported/w3c/resources/import-expectations.json:
* LayoutTests/imported/w3c/resources/resource-files.json:
* LayoutTests/imported/w3c/web-platform-tests/css/css-tables/paint/col-change-span-bg-invalidation-001-expected.xht: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-tables/paint/col-change-span-bg-invalidation-001.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-tables/paint/col-change-span-bg-invalidation-002-expected.xht: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-tables/paint/col-change-span-bg-invalidation-002.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-tables/paint/row-background-paint-remove-last-cell-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-tables/paint/row-background-paint-remove-last-cell-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-tables/paint/row-background-paint-remove-last-cell.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-tables/paint/w3c-import.log:
* Source/WebCore/rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::updateFromElement):

Upstream commit: https://github.com/web-platform-tests/wpt/commit/b2528beea2a54778f7314768d2352ccee8b7993f
Canonical link: https://commits.webkit.org/282969@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications