[webkit-changes] [WebKit/WebKit] c2423e: AX: Implement [WebAccessibilityObjectWrapper missp...

AndresGonzalezApple noreply at github.com
Fri Aug 30 04:07:22 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c2423ee74d49d167d457795485801bdd03bc8a33
      https://github.com/WebKit/WebKit/commit/c2423ee74d49d167d457795485801bdd03bc8a33
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2024-08-30 (Fri, 30 Aug 2024)

  Changed paths:
    M LayoutTests/accessibility/misspelling-range.html
    M Source/WebCore/accessibility/AXTextMarker.h
    M Source/WebCore/accessibility/cocoa/AXTextMarkerCocoa.mm
    M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.h
    M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm

  Log Message:
  -----------
  AX: Implement [WebAccessibilityObjectWrapper misspellingTextMarkerRange:forward:] on iOS using new AXSearchManager functionality.
https://bugs.webkit.org/show_bug.cgi?id=278876
<rdar://problem/134957919>

Reviewed by Tyler Wilcock.

This unifies the code paths for iOS and Mac to obtain the range of a misspelling. It also improves this functionality on iOS since now misspellingTextMarkerRange:forward: is not confined to the misspellings in the current object.

As a required byproduct of this changes, we added the conversion between AXTextMarkerRanges and NSArrays of TextMarkers used on iOS to represent ranges.

* LayoutTests/accessibility/misspelling-range.html:
* Source/WebCore/accessibility/AXTextMarker.h:
* Source/WebCore/accessibility/cocoa/AXTextMarkerCocoa.mm:
(WebCore::AXTextMarkerRange::AXTextMarkerRange):
(WebCore::AXTextMarkerRange::platformData const):
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.h:
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityTextMarker initWithTextMarker:cache:]):
(-[WebAccessibilityObjectWrapper stringForTextMarkers:]):
(-[WebAccessibilityObjectWrapper misspellingTextMarkerRange:forward:]):

Canonical link: https://commits.webkit.org/282959@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list