[webkit-changes] [WebKit/WebKit] f0d8b4: Use capture delegate for setCameraActive and setMi...

youennf noreply at github.com
Fri Aug 30 02:49:58 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f0d8b4a3a8bd1ffe48c7d52d005370ba42a0e272
      https://github.com/WebKit/WebKit/commit/f0d8b4a3a8bd1ffe48c7d52d005370ba42a0e272
  Author: Youenn Fablet <youenn at apple.com>
  Date:   2024-08-30 (Fri, 30 Aug 2024)

  Changed paths:
    A LayoutTests/http/wpt/mediasession/setCaptureState-permission-expected.txt
    A LayoutTests/http/wpt/mediasession/setCaptureState-permission.html
    M LayoutTests/http/wpt/mediasession/setCaptureState.html
    M Source/WebCore/Modules/mediasession/MediaSession.cpp
    M Source/WebCore/Modules/mediastream/UserMediaClient.h
    M Source/WebCore/Modules/mediastream/UserMediaController.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.messages.in
    M Source/WebKit/WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp
    M Source/WebKit/WebProcess/MediaStream/UserMediaPermissionRequestManager.h
    M Source/WebKit/WebProcess/WebCoreSupport/WebUserMediaClient.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebUserMediaClient.h
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
    M Tools/WebKitTestRunner/TestController.cpp
    M Tools/WebKitTestRunner/TestInvocation.cpp

  Log Message:
  -----------
  Use capture delegate for setCameraActive and setMicrophone active
https://bugs.webkit.org/show_bug.cgi?id=277494
rdar://problem/133041171

Reviewed by Eric Carlson.

In case the application (usually from a user decision) muted capture, WebKit is now asking whether the application is ok unmuting capture.
This allows to prompt the user as needed, reusing the same message as for starting capture.

* LayoutTests/http/wpt/mediasession/setCaptureState-permission-expected.txt: Added.
* LayoutTests/http/wpt/mediasession/setCaptureState-permission.html: Added.
* LayoutTests/http/wpt/mediasession/setCaptureState.html:
* Source/WebCore/Modules/mediasession/MediaSession.cpp:
(WebCore::MediaSession::updateCaptureState):
* Source/WebCore/Modules/mediastream/UserMediaClient.h:
* Source/WebCore/Modules/mediastream/UserMediaController.h:
(WebCore::UserMediaController::updateCaptureState):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::toUserMediaRequest):
(WebKit::WebPageProxy::updateCaptureState):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:
(WebKit::UserMediaPermissionRequestManager::updateCaptureState):
* Source/WebKit/WebProcess/MediaStream/UserMediaPermissionRequestManager.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebUserMediaClient.cpp:
(WebKit::WebUserMediaClient::updateCaptureState):
* Source/WebKit/WebProcess/WebCoreSupport/WebUserMediaClient.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updateCaptureState):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setMicrophonePermission):
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::setCaptureState):
* Tools/WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

Originally-landed-as: 0bf5b3bdea35. rdar://problem/133041171
Canonical link: https://commits.webkit.org/282954@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list