[webkit-changes] [WebKit/WebKit] 135df2: Revamp handling of notificationclick and notificat...

[Brady Eidson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 135df2fc81755218135e1a49886e6efe74a30a99
      https://github.com/WebKit/WebKit/commit/135df2fc81755218135e1a49886e6efe74a30a99
  Author: Brady Eidson <beidson at apple.com>
  Date:   2024-08-28 (Wed, 28 Aug 2024)

  Changed paths:
    M Source/WebKit/Platform/spi/Cocoa/UserNotificationsSPI.h
    M Source/WebKit/Platform/spi/ios/BaseBoardSPI.h
    M Source/WebKit/Platform/spi/ios/UIKitSPI.h
    M Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebPushAction.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKWebPushAction.mm
    A Source/WebKit/UIProcess/API/Cocoa/_WKWebPushActionInternal.h
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKit/webpushd/WebPushDaemon.mm

  Log Message:
  -----------
  Revamp handling of notificationclick and notificationclose
rdar://131365403
https://bugs.webkit.org/show_bug.cgi?id=278825

Reviewed by Ben Nham.

This reworks some logic in webpushd and in the WebKit UIProcess to properly
capture and route "notificationclick" and "notificationclose" events for
clients using built-in notifications.

* Source/WebKit/Platform/spi/ios/BaseBoardSPI.h:
* Source/WebKit/Platform/spi/ios/UIKitSPI.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(-[WKWebsiteDataStore _processWebCorePersistentNotificationClick:completionHandler:]):
(-[WKWebsiteDataStore _processPersistentNotificationClick:completionHandler:]):
(-[WKWebsiteDataStore _processWebCorePersistentNotificationClose:completionHandler:]):
(-[WKWebsiteDataStore _processPersistentNotificationClose:completionHandler:]):
(+[WKWebsiteDataStore _setWebPushActionHandler:]):
(-[WKWebsiteDataStore _handleNextPushMessage]):
(-[WKWebsiteDataStore _handleWebPushAction:]):
(-[_WKWebsiteDataStoreBSActionHandler _respondToApplicationActions:fromTransitionContext:]):
* Source/WebKit/UIProcess/API/Cocoa/_WKWebPushAction.h:
* Source/WebKit/UIProcess/API/Cocoa/_WKWebPushAction.mm:
(+[_WKWebPushAction _webPushActionWithNotificationResponse:]):
* Source/WebKit/UIProcess/API/Cocoa/_WKWebPushActionInternal.h: Copied from Source/WebKit/UIProcess/API/Cocoa/_WKWebPushAction.h.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/webpushd/WebPushDaemon.mm:
(WebPushD::platformDefaultActionBundleIdentifier):
(WebPushD::WebPushDaemon::notifyClientPushMessageIsAvailable):
(WebPushD::WebPushDaemon::showNotification):

Canonical link: https://commits.webkit.org/282885@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications