[webkit-changes] [WebKit/WebKit] 273f52: [ARMv7] Support running testb3

jjgriego noreply at github.com
Wed Aug 28 20:44:56 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 273f5243aa85af80bc22a9dbbd370efc61e726f6
      https://github.com/WebKit/WebKit/commit/273f5243aa85af80bc22a9dbbd370efc61e726f6
  Author: Joseph Griego <jgriego at igalia.com>
  Date:   2024-08-28 (Wed, 28 Aug 2024)

  Changed paths:
    M Source/JavaScriptCore/b3/B3Generate.cpp
    M Source/JavaScriptCore/b3/B3LowerToAir32_64.cpp
    M Source/JavaScriptCore/b3/B3Procedure.h
    M Source/JavaScriptCore/b3/air/AirCCallingConvention.cpp
    M Source/JavaScriptCore/b3/air/AirCCallingConvention.h
    M Source/JavaScriptCore/b3/air/AirCustom.cpp
    M Source/JavaScriptCore/b3/air/AirCustom.h
    M Source/JavaScriptCore/b3/air/AirLowerMacros.cpp
    M Source/JavaScriptCore/b3/testb3.h
    M Source/JavaScriptCore/b3/testb3_1.cpp
    M Source/JavaScriptCore/b3/testb3_2.cpp
    M Source/JavaScriptCore/b3/testb3_3.cpp
    M Source/JavaScriptCore/b3/testb3_4.cpp
    M Source/JavaScriptCore/b3/testb3_5.cpp
    M Source/JavaScriptCore/b3/testb3_6.cpp
    M Source/JavaScriptCore/b3/testb3_7.cpp
    M Source/JavaScriptCore/b3/testb3_8.cpp
    A Source/JavaScriptCore/b3/testb3_failingArmV7Tests.inc
    A Tools/Scripts/canonicalize-testb3-ir.py
    A Tools/Scripts/dump-testb3-ir

  Log Message:
  -----------
  [ARMv7] Support running testb3
https://bugs.webkit.org/show_bug.cgi?id=276367

Reviewed by OOPS.

This patch was written by Joseph Griego a while back. This does the following:

- Support running testb3 on armv7
- Allow dumping testb3 output, to ensure these changes don't affect other platforms

testb3 does not pass fully yet, but it does pass simple tests like testRotR.

I also added a list of skipped subtests, and confirmed on x86_64 and ARM64 (non-E)
that the generated B3 code is not changed.

To make these tests run, we mostly just abstract the calling convention away. Every
other change is mechanical.

Canonical link: https://commits.webkit.org/282881@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list