[webkit-changes] [WebKit/WebKit] 6968f2: AX: Implement the Mac AXMisspellingTextMarkerRange...

[AndresGonzalezApple]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6968f29a69b714d0328c16b2ef2f4986c3b9208c
      https://github.com/WebKit/WebKit/commit/6968f29a69b714d0328c16b2ef2f4986c3b9208c
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2024-08-28 (Wed, 28 Aug 2024)

  Changed paths:
    M LayoutTests/accessibility/search-misspellings.html
    M Source/WebCore/accessibility/AXCoreObject.h
    M Source/WebCore/accessibility/AXSearchManager.cpp
    M Source/WebCore/accessibility/AXSearchManager.h
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.h
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
    M Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h
    M Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm

  Log Message:
  -----------
  AX: Implement the Mac AXMisspellingTextMarkerRange API using the new AXSearchManager::findMatchingRange.
https://bugs.webkit.org/show_bug.cgi?id=278752
<rdar://problem/134820936>

Reviewed by Tyler Wilcock.

This allows the unification of the code paths for this functionality in both Mac and iOS. Fixes several bugs covered by misspelling-range.html and search-misspellings.html.

* LayoutTests/accessibility/search-misspellings.html:
Added setting the selection after finding a misspelling range which more closely resembles how VoiceOver uses this API.
* Source/WebCore/accessibility/AXCoreObject.h:
* Source/WebCore/accessibility/AXSearchManager.cpp:
(WebCore::AXSearchManager::matchForSearchKeyAtIndex):
(WebCore::AXSearchManager::findMatchingObjectsInternal):
(WebCore::AXSearchManager::findMatchingRange):
* Source/WebCore/accessibility/AXSearchManager.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::misspellingRanges const):
(WebCore::AccessibilityObject::spellCheckerResultRanges const): Renamed misspellingRanges.
* Source/WebCore/accessibility/AccessibilityObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::misspellingRanges const):
(WebCore::AXIsolatedObject::spellCheckerResultRanges const): Renamed.
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h:
* Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

Canonical link: https://commits.webkit.org/282874@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications