[webkit-changes] [WebKit/WebKit] d15668: Drop NetworkNotificationManager::m_isEphemeralSession

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d15668b0d680af2a450acea264828322a00a7f2c
      https://github.com/WebKit/WebKit/commit/d15668b0d680af2a450acea264828322a00a7f2c
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2024-08-28 (Wed, 28 Aug 2024)

  Changed paths:
    M Source/WebKit/NetworkProcess/NetworkProcess.cpp
    M Source/WebKit/NetworkProcess/NetworkSession.cpp
    M Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.cpp
    M Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.h

  Log Message:
  -----------
  Drop NetworkNotificationManager::m_isEphemeralSession
https://bugs.webkit.org/show_bug.cgi?id=278758
rdar://134828317

Reviewed by Ben Nham.

NetworkNotificationManager only needs the information at creation to decide whether connection to daemon should be
created, and it's unnecessary to have a data member. Also, we need to always construct NetworkNotificationManager as
it is the message handler for NotificationManagerMessageHandler messages with current implementation. When connection
cannot be establisehd (like in ephemeral session), we want to respond those message with error or empty result , instead
of ignoring them.

This patch also contains a drive-by fix that callback may not be invoked in NetworkProcess::getPendingPushMessage.

* Source/WebKit/NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::getPendingPushMessages):
* Source/WebKit/NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::NetworkSession):
* Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.cpp:
(WebKit::NetworkNotificationManager::NetworkNotificationManager):
(WebKit::NetworkNotificationManager::requestPermission):
(WebKit::NetworkNotificationManager::getPushSubscription):
* Source/WebKit/NetworkProcess/Notifications/NetworkNotificationManager.h:

Canonical link: https://commits.webkit.org/282867@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications