[webkit-changes] [WebKit/WebKit] 4ccf22: Exit viewer mode when clicked outside of video con...

Dana Estra noreply at github.com
Wed Aug 28 10:35:47 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4ccf22bf88fed32863151af9b46875887b436a3e
      https://github.com/WebKit/WebKit/commit/4ccf22bf88fed32863151af9b46875887b436a3e
  Author: Dana Estra <destra at apple.com>
  Date:   2024-08-28 (Wed, 28 Aug 2024)

  Changed paths:
    M Source/WebCore/Modules/modern-media-controls/media/media-controller.js

  Log Message:
  -----------
  Exit viewer mode when clicked outside of video content
https://bugs.webkit.org/show_bug.cgi?id=278746
rdar://134813550

Reviewed by Jer Noble.

It could be nice to exit Viewer when the page is clicked outside of the
video content.

If the <video> receives a click event, and the <video> is also the target
of this event, this means we have clicked outside the border of the
media controls <div>, which covers the video content.

* Source/WebCore/Modules/modern-media-controls/media/media-controller.js:
(MediaController):
(MediaController.prototype.handleEvent):

Canonical link: https://commits.webkit.org/282849@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list