[webkit-changes] [WebKit/WebKit] ecbfda: Cherry-pick 282758 at main (6fa76748bda6). https://bu...

[Carlos Garcia Campos]

  Branch: refs/heads/webkitglib/2.46
  Home:   https://github.com/WebKit/WebKit
  Commit: ecbfdabda4f09d21eb09aa474b829ddfea2cfb27
      https://github.com/WebKit/WebKit/commit/ecbfdabda4f09d21eb09aa474b829ddfea2cfb27
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-08-28 (Wed, 28 Aug 2024)

  Changed paths:
    M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  -----------
  Cherry-pick 282758 at main (6fa76748bda6). https://bugs.webkit.org/show_bug.cgi?id=278656

    Regression(281966 at main) Crash under WebPageProxy::didChooseFilesForOpenPanelWithDisplayStringAndIcon()
    https://bugs.webkit.org/show_bug.cgi?id=278656
    rdar://134586628

    Reviewed by Pascoe.

    Null check m_openPanelResultListener before dereferencing it.

    * Source/WebKit/UIProcess/WebPageProxy.cpp:
    (WebKit::WebPageProxy::didChooseFilesForOpenPanelWithDisplayStringAndIcon):
    (WebKit::WebPageProxy::didChooseFilesForOpenPanel):
    (WebKit::WebPageProxy::didCancelForOpenPanel):

    Canonical link: https://commits.webkit.org/282758@main


  Commit: dc720ea8393045f8597d062331a4ec1cc8534397
      https://github.com/WebKit/WebKit/commit/dc720ea8393045f8597d062331a4ec1cc8534397
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2024-08-28 (Wed, 28 Aug 2024)

  Changed paths:
    M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  -----------
  Cherry-pick 282833 at main (833f10581362). https://bugs.webkit.org/show_bug.cgi?id=278648

    REGRESSION(281966 at main): [GTK] Crash when drag-dropping files to gitlab issues
    https://bugs.webkit.org/show_bug.cgi?id=278648

    Reviewed by Adrian Perez de Castro.

    There are two problems here:

      - We take a weak pointer to the page proxy that is not checked. I'm
        not sure this is a problem in the end, because the completion
        handler is protecting this. But since the weak pointer is used, I
        think it's better to check it, just in case the completion handler
        changes in the future.

      - The weak pointer is used after being moved.

    * Source/WebKit/UIProcess/WebPageProxy.cpp:
    (WebKit::WebPageProxy::performDragControllerAction):

    Canonical link: https://commits.webkit.org/282833@main


  Commit: bb76b1e57b24c9b3f84940ef9105f2cb2c77fd67
      https://github.com/WebKit/WebKit/commit/bb76b1e57b24c9b3f84940ef9105f2cb2c77fd67
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2024-08-28 (Wed, 28 Aug 2024)

  Changed paths:
    M Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp
    M Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp
    M Source/WebKit/UIProcess/gtk/Display.cpp

  Log Message:
  -----------
  Cherry-pick 282555 at main (f83fd3eb47e9). https://bugs.webkit.org/show_bug.cgi?id=278380

    REGRESSION(282416 at main): [GTK] link error with wayland and GBM disabled
    https://bugs.webkit.org/show_bug.cgi?id=278380

    Reviewed by Miguel Gomez.

    Fix the build with ENABLE_WAYLAND_TARGET=OFF and USE_GBM=OFF

    * Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
    (WebKit::bubblewrapSpawn):
    * Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp:
    * Source/WebKit/UIProcess/gtk/Display.cpp:
    (WebKit::Display::isX11 const):
    (WebKit::Display::isWayland const):

    Canonical link: https://commits.webkit.org/282555@main


Compare: https://github.com/WebKit/WebKit/compare/ab88b07d5f7f...bb76b1e57b24

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications