[webkit-changes] [WebKit/WebKit] 833f10: REGRESSION(281966 at main): [GTK] Crash when drag-dro...

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 833f10581362f465c75f5f8c2e2e8e4febff8504
      https://github.com/WebKit/WebKit/commit/833f10581362f465c75f5f8c2e2e8e4febff8504
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2024-08-28 (Wed, 28 Aug 2024)

  Changed paths:
    M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  -----------
  REGRESSION(281966 at main): [GTK] Crash when drag-dropping files to gitlab issues
https://bugs.webkit.org/show_bug.cgi?id=278648

Reviewed by Adrian Perez de Castro.

There are two problems here:

  - We take a weak pointer to the page proxy that is not checked. I'm
    not sure this is a problem in the end, because the completion
    handler is protecting this. But since the weak pointer is used, I
    think it's better to check it, just in case the completion handler
    changes in the future.

  - The weak pointer is used after being moved.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::performDragControllerAction):

Canonical link: https://commits.webkit.org/282833@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications