[webkit-changes] [WebKit/WebKit] a85951: Remove invalid `writing-mode` from `:cue` in `text...

Ahmad Saleem noreply at github.com
Tue Aug 27 15:00:50 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a85951c0c3d642016a1c87971ece0dd0f6c4995c
      https://github.com/WebKit/WebKit/commit/a85951c0c3d642016a1c87971ece0dd0f6c4995c
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2024-08-27 (Tue, 27 Aug 2024)

  Changed paths:
    M Source/WebCore/Modules/modern-media-controls/controls/text-tracks.css

  Log Message:
  -----------
  Remove invalid `writing-mode` from `:cue` in `text-tracks.css`

https://bugs.webkit.org/show_bug.cgi?id=278735
rdar://134793230

Reviewed by Jer Noble.

This patch removes invalid CSS `writing-mode: writing-mode` configured
for `:cue` in `text-tracks.css` as per web specification [1], since it is
variable value.

[1] https://w3c.github.io/webvtt/#applying-css-properties

For `writing-mode` implementation, refer to `VTTCue::getCSSWritingMode()`.

* Source/WebCore/Modules/modern-media-controls/controls/text-tracks.css:
([useragentpart="cue"]):

Canonical link: https://commits.webkit.org/282820@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list