[webkit-changes] [WebKit/WebKit] 74dcb4: [web-animations] Physical properties should take p...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 74dcb4aac602ab55cee2d8b3f7e7b3ea263a538d
      https://github.com/WebKit/WebKit/commit/74dcb4aac602ab55cee2d8b3f7e7b3ea263a538d
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2024-08-27 (Tue, 27 Aug 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-logical/animation-001-expected.txt
    M Source/WebCore/animation/KeyframeEffect.cpp

  Log Message:
  -----------
  [web-animations] Physical properties should take priority over logical properties
https://bugs.webkit.org/show_bug.cgi?id=277334
rdar://133278333

Reviewed by Antti Koivisto.

When processing the list of animated CSS properties for a keyframe provided via the JS API,
we must ensure that we group them in such a way that longhands win over shorthands and that
physical properties win over logical properties. We now divide CSS properties encountered
via the JS API in four distinct groups organized as follows:

1. logical shorthands
2. physical shorthands
3. logical longhands
4. physical longhands

In this list, the later properties win over the earlier properties.

This allows us to recover from 281543 at main which regressed the two subtests that are now
PASS results again.

* LayoutTests/imported/w3c/web-platform-tests/css/css-logical/animation-001-expected.txt:
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::processKeyframeLikeObject):

Canonical link: https://commits.webkit.org/282815@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications