[webkit-changes] [WebKit/WebKit] 9a8ecb: popovertarget on button type=button in form doesn'...

Luke Warlow noreply at github.com
Tue Aug 27 10:30:02 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9a8ecbaa8fc59d6f4336fffe04c31986cdc5e92e
      https://github.com/WebKit/WebKit/commit/9a8ecbaa8fc59d6f4336fffe04c31986cdc5e92e
  Author: Luke Warlow <lwarlow at igalia.com>
  Date:   2024-08-27 (Tue, 27 Aug 2024)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-popovertarget-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-popovertarget.html
    R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-reset-popovertarget.tentative-expected.txt
    R LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-reset-popovertarget.tentative.html
    M Source/WebCore/html/HTMLButtonElement.cpp

  Log Message:
  -----------
  popovertarget on button type=button in form doesn't work
https://bugs.webkit.org/show_bug.cgi?id=275899

Reviewed by Darin Adler.

This patch fixes an issue where buttons with popovertarget never work when inside a form.

* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-popovertarget-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-popovertarget.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-reset-popovertarget.tentative-expected.txt: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/button-type-reset-popovertarget.tentative.html: Removed.
* Source/WebCore/html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::defaultEventHandler):

Canonical link: https://commits.webkit.org/282801@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list