[webkit-changes] [WebKit/WebKit] 77992f: [JSC] Remove unnecessary memmove and strlen for dr...

Yusuke Suzuki noreply at github.com
Tue Aug 27 09:39:44 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 77992f06d88e04b09ba1e097b8297932df5305c1
      https://github.com/WebKit/WebKit/commit/77992f06d88e04b09ba1e097b8297932df5305c1
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2024-08-27 (Tue, 27 Aug 2024)

  Changed paths:
    M Source/JavaScriptCore/runtime/JSONObject.cpp
    M Source/WTF/wtf/dragonbox/dragonbox_to_chars.h

  Log Message:
  -----------
  [JSC] Remove unnecessary memmove and strlen for dragonbox ToShortest
https://bugs.webkit.org/show_bug.cgi?id=278703
rdar://134763943

Reviewed by Yijia Huang.

1. dragonbox::ToExponential / dragonbox::ToShortest were doing unnecessary strlen. This patch removes it.
2. FastStringifier employs dragonbox::to_char_n directly so that we remove one more unnecessary memmove observed in the profile.

* Source/JavaScriptCore/runtime/JSONObject.cpp:
(JSC::bufferMode>::append):
* Source/WTF/wtf/dragonbox/dragonbox_to_chars.h:
(WTF::dragonbox::ToExponential):
(WTF::dragonbox::ToShortest):

Canonical link: https://commits.webkit.org/282798@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list