[webkit-changes] [WebKit/WebKit] ed97c3: Fix assert related to preference update

Per Arne Vollan noreply at github.com
Mon Aug 26 21:00:57 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ed97c378c849c4af7b59daaa4851bc35212c81cf
      https://github.com/WebKit/WebKit/commit/ed97c378c849c4af7b59daaa4851bc35212c81cf
  Author: Per Arne Vollan <pvollan at apple.com>
  Date:   2024-08-26 (Mon, 26 Aug 2024)

  Changed paths:
    M Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm

  Log Message:
  -----------
  Fix assert related to preference update
https://bugs.webkit.org/show_bug.cgi?id=278689
rdar://134746970

Reviewed by Chris Dumez and Richard Robinson.

In some cases we hit an assert when updating preferences sent from the UI process. This can happen
when the preference has been set by an underlying framework in the volatile preference domain. The
value we get when reading the preference will not be the expected one, then, since the volatile
domain comes very early in the preference search order. This patch addresses this by adding an
exception for this preference key.

* Source/WebKit/Shared/Cocoa/AuxiliaryProcessCocoa.mm:
(WebKit::AuxiliaryProcess::setPreferenceValue):

Canonical link: https://commits.webkit.org/282773@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list