[webkit-changes] [WebKit/WebKit] f4b28e: [Writing Tools] Stylized text disappears when clic...

[Richard Robinson]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f4b28e23dc4028dce7f7663bf6a0534231d034a5
      https://github.com/WebKit/WebKit/commit/f4b28e23dc4028dce7f7663bf6a0534231d034a5
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2024-08-26 (Mon, 26 Aug 2024)

  Changed paths:
    M Source/WebCore/page/writing-tools/WritingToolsController.h
    M Source/WebCore/page/writing-tools/WritingToolsController.mm
    M Source/WebCore/testing/Internals.cpp
    M Source/WebCore/testing/Internals.h
    M Source/WebCore/testing/Internals.idl
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm

  Log Message:
  -----------
  [Writing Tools] Stylized text disappears when clicking on show original
https://bugs.webkit.org/show_bug.cgi?id=278573
rdar://133809455

Reviewed by Abrar Rahman Protyasha.

Persist the transparent document markers after a replacement occurs to ensure that they do not
erroneously get re-added after undo-ing as a result of "Show Original".

* Source/WebCore/page/writing-tools/WritingToolsController.h:
* Source/WebCore/page/writing-tools/WritingToolsController.mm:
(WebCore::WritingToolsController::showSelection const):
(WebCore::WritingToolsController::compositionSessionDidReceiveTextWithReplacementRangeAsync):
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::hasTransparentContentMarker):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WritingTools.mm:
(TEST(WritingTools, CompositionShowOriginalHasNoTransparentMarkers)):

Canonical link: https://commits.webkit.org/282750@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications