[webkit-changes] [WebKit/WebKit] 2d6f98: REGRESSION(282416 at main): [GTK] crash loading WebGL...

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2d6f98bbc33faf735064ad081f301e6f2e7430d2
      https://github.com/WebKit/WebKit/commit/2d6f98bbc33faf735064ad081f301e6f2e7430d2
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2024-08-25 (Sun, 25 Aug 2024)

  Changed paths:
    M Source/WebCore/PlatformGTK.cmake
    M Source/WebCore/SourcesGTK.txt
    M Source/WebCore/platform/graphics/PlatformDisplay.h
    M Source/WebCore/platform/graphics/egl/GLContext.cpp
    A Source/WebCore/platform/graphics/egl/PlatformDisplayDefault.cpp
    A Source/WebCore/platform/graphics/egl/PlatformDisplayDefault.h
    M Source/WebCore/platform/graphics/egl/PlatformDisplaySurfaceless.cpp
    M Source/WebCore/platform/graphics/gbm/PlatformDisplayGBM.cpp
    M Source/WebCore/platform/graphics/libwpe/PlatformDisplayLibWPE.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
    M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp
    M Source/WebKit/WebProcess/WebProcess.h
    M Source/WebKit/WebProcess/glib/WebProcessGLib.cpp

  Log Message:
  -----------
  REGRESSION(282416 at main): [GTK] crash loading WebGL with accelerated compositing disabled under X11
https://bugs.webkit.org/show_bug.cgi?id=278461

Reviewed by Miguel Gomez.

In case of GTK, create the PlatformDisplay when accelerated compositing
is enabled or when a WebGL context is created. Also add a Default
PlatformDisplay to be used for WebGL when GBM and Surfaceless EGL
platforms are not supported.

* Source/WebCore/PlatformGTK.cmake:
* Source/WebCore/SourcesGTK.txt:
* Source/WebCore/platform/graphics/PlatformDisplay.h:
* Source/WebCore/platform/graphics/egl/GLContext.cpp:
(WebCore::GLContext::createWindowContext):
* Source/WebCore/platform/graphics/egl/PlatformDisplayDefault.cpp: Added.
(WebCore::PlatformDisplayDefault::create):
(WebCore::PlatformDisplayDefault::PlatformDisplayDefault):
(WebCore::PlatformDisplayDefault::~PlatformDisplayDefault):
* Source/WebCore/platform/graphics/egl/PlatformDisplayDefault.h: Added.
* Source/WebCore/platform/graphics/egl/PlatformDisplaySurfaceless.cpp:
(WebCore::PlatformDisplaySurfaceless::create):
* Source/WebCore/platform/graphics/gbm/PlatformDisplayGBM.cpp:
(WebCore::PlatformDisplayGBM::create):
* Source/WebCore/platform/graphics/libwpe/PlatformDisplayLibWPE.cpp:
(WebCore::PlatformDisplayLibWPE::create):
* Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createGraphicsContextGL const):
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
(WebKit::DrawingAreaCoordinatedGraphics::updatePreferences):
* Source/WebKit/WebProcess/WebProcess.h:
* Source/WebKit/WebProcess/glib/WebProcessGLib.cpp:
(WebKit::WebProcess::initializePlatformDisplayIfNeeded const):
(WebKit::WebProcess::platformInitializeWebProcess):

Canonical link: https://commits.webkit.org/282721@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications