[webkit-changes] [WebKit/WebKit] 560ddc: [Cleanup] Rename RenderText/RenderInline legacy li...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 560ddc1032db55853df0a5c33829f621e98316e6
      https://github.com/WebKit/WebKit/commit/560ddc1032db55853df0a5c33829f621e98316e6
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-08-25 (Sun, 25 Aug 2024)

  Changed paths:
    M Source/WebCore/rendering/LegacyInlineFlowBox.cpp
    M Source/WebCore/rendering/LegacyLineLayout.cpp
    M Source/WebCore/rendering/RenderInline.cpp
    M Source/WebCore/rendering/RenderInline.h
    M Source/WebCore/rendering/RenderMenuList.cpp
    M Source/WebCore/rendering/RenderQuote.cpp
    M Source/WebCore/rendering/RenderText.cpp
    M Source/WebCore/rendering/RenderText.h
    M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp
    M Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp

  Log Message:
  -----------
  [Cleanup] Rename RenderText/RenderInline legacy line functions (e.g. dirtyLineBoxes -> dirtyLegacyLineBoxes)
https://bugs.webkit.org/show_bug.cgi?id=278581

Reviewed by Antti Koivisto.

This helps to find places where we might miss invalidation on non-legacy lines.

* Source/WebCore/rendering/LegacyInlineFlowBox.cpp:
(WebCore::LegacyInlineFlowBox::removeLineBoxFromRenderObject):
(WebCore::LegacyInlineFlowBox::extractLineBoxFromRenderObject):
(WebCore::LegacyInlineFlowBox::attachLineBoxToRenderObject):
* Source/WebCore/rendering/LegacyLineLayout.cpp:
(WebCore::dirtyLineBoxesForRenderer):
* Source/WebCore/rendering/RenderInline.cpp:
(WebCore::RenderInline::willBeDestroyed):
(WebCore::RenderInline::paint):
(WebCore::RenderInline::nodeAtPoint):
(WebCore::RenderInline::dirtyLegacyLineBoxes):
(WebCore::RenderInline::deleteLegacyLines):
(WebCore::RenderInline::createAndAppendInlineFlowBox):
(WebCore::RenderInline::dirtyLineBoxes): Deleted.
(WebCore::RenderInline::deleteLines): Deleted.
* Source/WebCore/rendering/RenderInline.h:
(WebCore::RenderInline::legacyLineBoxes):
(WebCore::RenderInline::legacyLineBoxes const):
(WebCore::RenderInline::firstLegacyInlineBox const):
(WebCore::RenderInline::lastLegacyInlineBox const):
(WebCore::RenderInline::lineBoxes): Deleted.
(WebCore::RenderInline::lineBoxes const): Deleted.
* Source/WebCore/rendering/RenderMenuList.cpp:
(RenderMenuList::setText):
* Source/WebCore/rendering/RenderQuote.cpp:
(WebCore::RenderQuote::updateTextRenderer):
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::RenderText::removeAndDestroyLegacyTextBoxes):
(WebCore::RenderText::willBeDestroyed):
(WebCore::RenderText::setTextWithOffset):
(WebCore::RenderText::dirtyLegacyLineBoxes):
(WebCore::RenderText::deleteLegacyLineBoxes):
(WebCore::RenderText::removeAndDestroyTextBoxes): Deleted.
(WebCore::RenderText::dirtyLineBoxes): Deleted.
(WebCore::RenderText::deleteLineBoxes): Deleted.
* Source/WebCore/rendering/RenderText.h:
(WebCore::RenderText::extractTextBox):
(WebCore::RenderText::attachTextBox):
(WebCore::RenderText::removeTextBox):
(WebCore::RenderText::createInlineTextBox):
(WebCore::RenderText::firstTextBox const):
(WebCore::RenderText::lastTextBox const):
* Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:
(WebCore::resetRendererStateOnDetach):
* Source/WebCore/rendering/updating/RenderTreeBuilderFirstLetter.cpp:
(WebCore::RenderTreeBuilder::FirstLetter::updateStyle):

Canonical link: https://commits.webkit.org/282711@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications