[webkit-changes] [WebKit/WebKit] d39e86: Cherry-pick 282655 at main (a3728bae9407). https://bu...

[Alex Christensen]

  Branch: refs/heads/webkitglib/2.46
  Home:   https://github.com/WebKit/WebKit
  Commit: d39e864360ecc0c8bf5e72cd795853fd92c7bddf
      https://github.com/WebKit/WebKit/commit/d39e864360ecc0c8bf5e72cd795853fd92c7bddf
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-08-25 (Sun, 25 Aug 2024)

  Changed paths:
    M Source/WebKit/Shared/LoadParameters.h
    M Source/WebKit/Shared/LoadParameters.serialization.in
    M Source/WebKit/UIProcess/API/C/WKPage.cpp
    M Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm
    M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
    M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp
    M Source/WebKit/UIProcess/Cocoa/SOAuthorization/RedirectSOAuthorizationSession.mm
    M Source/WebKit/UIProcess/ProvisionalPageProxy.cpp
    M Source/WebKit/UIProcess/ProvisionalPageProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp

  Log Message:
  -----------
  Cherry-pick 282655 at main (a3728bae9407). https://bugs.webkit.org/show_bug.cgi?id=278550

    Fix std::span lifetime issues after 281966 at main
    https://bugs.webkit.org/show_bug.cgi?id=278550
    rdar://134358987

    Reviewed by Pascoe.

    loadParameters.data is a std::span, so we need to keep the data alive until it is actually sent.
    I use a SharedBuffer as basically a platform-agnostic RetainPtr<NSData> to accomplish this.

    * Source/WebKit/UIProcess/API/C/WKPage.cpp:
    (WKPageLoadData):
    (WKPageLoadDataWithUserData):
    (loadString):
    * Source/WebKit/UIProcess/API/Cocoa/WKBrowsingContextController.mm:
    (-[WKBrowsingContextController loadHTMLString:baseURL:userData:]):
    (-[WKBrowsingContextController loadData:MIMEType:textEncodingName:baseURL:userData:]):
    * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
    (-[WKWebView loadData:MIMEType:characterEncodingName:baseURL:]):
    (-[WKWebView loadSimulatedRequest:response:responseData:]):
    (-[WKWebView _loadData:MIMEType:characterEncodingName:baseURL:userData:]):
    * Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:
    (webkit_web_view_load_html):
    (webkit_web_view_load_plain_text):
    (webkit_web_view_load_bytes):
    * Source/WebKit/UIProcess/Cocoa/SOAuthorization/RedirectSOAuthorizationSession.mm:
    (WebKit::RedirectSOAuthorizationSession::completeInternal):
    * Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:
    (WebKit::ProvisionalPageProxy::loadData):
    * Source/WebKit/UIProcess/ProvisionalPageProxy.h:
    * Source/WebKit/UIProcess/WebPageProxy.cpp:
    (WebKit::WebPageProxy::loadData):
    (WebKit::WebPageProxy::loadDataWithNavigationShared):
    (WebKit::WebPageProxy::loadSimulatedRequest):
    (WebKit::WebPageProxy::loadAlternateHTML):
    (WebKit::WebPageProxy::continueNavigationInNewProcess):
    (WebKit::WebPageProxy::loadServiceWorker):
    * Source/WebKit/UIProcess/WebPageProxy.h:

    Canonical link: https://commits.webkit.org/282655@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications