[webkit-changes] [WebKit/WebKit] 4c1901: REGRESSION (279835 at main): "My Ride K-12" iOS app f...

Wenson Hsieh noreply at github.com
Sat Aug 24 23:07:27 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4c19011fb597f5a2d919da6beacb3474716a54ff
      https://github.com/WebKit/WebKit/commit/4c19011fb597f5a2d919da6beacb3474716a54ff
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2024-08-24 (Sat, 24 Aug 2024)

  Changed paths:
    M Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.cpp
    M Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h
    M Source/WebCore/loader/cache/CachedResourceLoader.cpp
    M Source/WebCore/platform/RuntimeApplicationChecks.h
    M Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm
    M Source/WebCore/platform/network/DNS.cpp

  Log Message:
  -----------
  REGRESSION (279835 at main): "My Ride K-12" iOS app fails to load
https://bugs.webkit.org/show_bug.cgi?id=278614
rdar://134204964

Reviewed by Chris Dumez.

The "My Ride K-12" app on iOS currently relies on navigating a web view to `0.0.0.0` for login.
After the changes in 279835 at main, this no longer works because the load is blocked.

Mitigate this by adding a linked-on-or-after check guarded behind an additional app bundle ID check,
so that the app will be forced to adapt to this change in order to move to the iOS 18 SDK (and then
we can subsequently remove this code).

* Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.cpp:
(WTF::computeSDKAlignedBehaviors):
* Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h:
* Source/WebCore/loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
* Source/WebCore/platform/RuntimeApplicationChecks.h:
* Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm:
(WebCore::IOSApplication::isMyRideK12):
* Source/WebCore/platform/network/DNS.cpp:
(WebCore::isIPAddressDisallowed):

Canonical link: https://commits.webkit.org/282709@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list